Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

save was being blocked if effects were turned off #9053

Merged
merged 1 commit into from
Oct 13, 2023
Merged

save was being blocked if effects were turned off #9053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/editor/src/functions/takeScreenshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,9 @@ export async function takeScreenshot(
scenePreviewCamera.layers.disableAll()
scenePreviewCamera.layers.set(ObjectLayers.Scene)

const selection = EngineRenderer.instance.effectComposer.HighlightEffect.selection.values()
const selection = EngineRenderer.instance.effectComposer.HighlightEffect?.selection.values()
if (hideHelpers) {
EngineRenderer.instance.effectComposer.HighlightEffect.clearSelection()
EngineRenderer.instance.effectComposer.HighlightEffect?.clearSelection()
}

const originalSize = EngineRenderer.instance.renderer.getSize(new Vector2())
Expand Down Expand Up @@ -230,7 +230,7 @@ export async function takeScreenshot(
EngineRenderer.instance.effectComposer.render()

if (hideHelpers) {
EngineRenderer.instance.effectComposer.HighlightEffect.setSelection(selection)
EngineRenderer.instance.effectComposer.HighlightEffect?.setSelection(selection)
}

const canvas = getResizedCanvas(EngineRenderer.instance.renderer.domElement, width, height)
Expand Down