Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

anselm
Copy link
Contributor

@anselm anselm commented Oct 13, 2023

Summary

🤖 Generated by Copilot at 5033f01

Fixed screenshot errors and selection loss in editor. Improved takeScreenshot.ts code with optional chaining.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 5033f01

  • Prevent errors and crashes when taking a screenshot with the highlight effect disabled or the hide helpers option enabled (link, link)

🤖 Generated by Copilot at 5033f01

When taking a screenshot with code
You don't want to lose your selection mode
So HighlightEffect got some checks
With optional chaining syntax
To fix issue #113 and lighten the load

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@speigg speigg added this pull request to the merge queue Oct 13, 2023
Merged via the queue into dev with commit 1596d02 Oct 13, 2023
@speigg speigg deleted the highlight-save branch October 13, 2023 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants