Enable bfloat16 unit tests #5163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
commented
Sep 23, 2025
| @@ -1 +1 @@ | |||
| 8e8c02c4b803062501a6bd36aecdbb041fa1daef | |||
| 31c82e8cfc7cec7ab1cd8d3359fdd8781780c91c | |||
There was a problem hiding this comment.
Need to go back to an older commit, as KhronosGroup/SPIRV-LLVM-Translator@8242eb7 makes some tests fail. Problem and reproducer is reported to the author.
There was a problem hiding this comment.
Note: 31c82e8cfc7cec7ab1cd8d3359fdd8781780c91c is is the older commit.
etiotto
approved these changes
Sep 24, 2025
| @@ -1 +1 @@ | |||
| 8e8c02c4b803062501a6bd36aecdbb041fa1daef | |||
| 31c82e8cfc7cec7ab1cd8d3359fdd8781780c91c | |||
There was a problem hiding this comment.
Note: 31c82e8cfc7cec7ab1cd8d3359fdd8781780c91c is is the older commit.
|
|
||
| FetchContent_MakeAvailable(spirv-llvm-translator) | ||
|
|
||
| # FIXME: Don't apply patch when Agama driver is updated. |
There was a problem hiding this comment.
Removing old hack now that we have a new driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes
SPV_KHR_bfloat16workaround.Block by driver update.
CI with Agama 1188: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/17932864080 (PASS)
Fixes #3914