-
Notifications
You must be signed in to change notification settings - Fork 73
WIP: Generate FMA loop #5097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: Generate FMA loop #5097
Conversation
Signed-off-by: Ettore Tiotto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This WIP (Work in Progress) PR implements loop generation for FMA (Fused Multiply-Add) operations in the TritonGPU to LLVM conversion. It introduces a new code generation mode that generates loops instead of unrolled code for dot operations.
- Adds loop-based code generation as an alternative to the existing unrolled approach
- Implements helper functions to create control flow loops using MLIR's ControlFlow dialect
- Integrates the loop generation into the existing FMA dot operation conversion pipeline
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
llvm::errs() << "at line: " << __LINE__ << "\n"; | ||
llvm::errs() << "Module after:\n"; | ||
mod->dumpPretty(); | ||
llvm::errs() << "\n"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug output statements should be removed from production code. These debugging prints will pollute the output in release builds.
llvm::errs() << "at line: " << __LINE__ << "\n"; | |
llvm::errs() << "Module after:\n"; | |
mod->dumpPretty(); | |
llvm::errs() << "\n"; |
Copilot uses AI. Check for mistakes.
Signed-off-by: Ettore Tiotto <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Ettore Tiotto <[email protected]>
No description provided.