Skip to content

Conversation

etiotto
Copy link
Contributor

@etiotto etiotto commented Sep 12, 2025

No description provided.

Signed-off-by: Ettore Tiotto <[email protected]>
@etiotto etiotto requested a review from Copilot September 12, 2025 16:55
@etiotto etiotto self-assigned this Sep 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This WIP (Work in Progress) PR implements loop generation for FMA (Fused Multiply-Add) operations in the TritonGPU to LLVM conversion. It introduces a new code generation mode that generates loops instead of unrolled code for dot operations.

  • Adds loop-based code generation as an alternative to the existing unrolled approach
  • Implements helper functions to create control flow loops using MLIR's ControlFlow dialect
  • Integrates the loop generation into the existing FMA dot operation conversion pipeline

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 339 to 343
llvm::errs() << "at line: " << __LINE__ << "\n";
llvm::errs() << "Module after:\n";
mod->dumpPretty();
llvm::errs() << "\n";

Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug output statements should be removed from production code. These debugging prints will pollute the output in release builds.

Suggested change
llvm::errs() << "at line: " << __LINE__ << "\n";
llvm::errs() << "Module after:\n";
mod->dumpPretty();
llvm::errs() << "\n";

Copilot uses AI. Check for mistakes.

@etiotto etiotto linked an issue Sep 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant