Skip to content

[aio-pika] Enable consumer callback tracing #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

[aio-pika] Enable consumer callback tracing #795

merged 2 commits into from
Sep 5, 2025

Conversation

tobmi1
Copy link
Contributor

@tobmi1 tobmi1 commented Sep 2, 2025 •
edited
Loading

Addresses #794.

The following changes were made:

  • Move the execution of the consumer callback in the aio-pika´ consume wrapper into the with` statement that constitutes the consumer span. This enables tracing of further calls made in the consumer callback function.
  • Add a test to check if exceptions thrown in the consumer callback function are recorded by Instana. This fails against the current main branch and passes with the changes in this PR.

@tobmi1 tobmi1 marked this pull request as ready for review September 2, 2025 19:21
@tobmi1 tobmi1 requested a review from a team as a code owner September 2, 2025 19:21
@GSVarsha GSVarsha self-assigned this Sep 5, 2025
@GSVarsha GSVarsha added this to the H2-2025 milestone Sep 5, 2025
GSVarsha
GSVarsha approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@GSVarsha GSVarsha merged commit d412bd7 into instana:main Sep 5, 2025
17 of 19 checks passed
@GSVarsha GSVarsha linked an issue Sep 5, 2025 that may be closed by this pull request
[Bug]: aio-pika wrapper does not trace consumer callback #794
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

@GSVarsha GSVarsha

Labels
bug fix
Projects
None yet
Milestone
H2-2025
Development

Successfully merging this pull request may close these issues.

[Bug]: aio-pika wrapper does not trace consumer callback
2 participants
@tobmi1 @GSVarsha