[Bug]: aio-pika wrapper does not trace consumer callback

[tobmi1]

Problem Description

Hi,
we are using aio-pika and RabbitMQ to realize a federated master-worker pattern where a single master puts tasks on a queue and multiple workers consume those tasks via a callback. Ever since support for aio-pika was added to the instana python sensor, we were able to see events for tasks being published and consumed in our traces (which is already pretty awesome ☺️).

However, any further calls made in the consumer callback method do not appear in the trace. I believe this could be due to a bug in the instana wrapper implementation:

python-sensor/src/instana/instrumentation/aio_pika.py

Lines 97 to 108 in ad0fb4b

	with tracer.start_as_current_span(
	"rabbitmq", span_context=parent_context
	) as span:
	_extract_span_attributes(
	span, connection, "consume", message.routing_key, message.exchange
	)
	try:
	response = await wrapped(*args, **kwargs)
	except Exception as exc:
	span.record_exception(exc)
	else:
	return response

The code that actually executes the consumer callback wrapper (l. 104) is not contained in the with statement that constitutes the span.
Compare this to the regular pika wrapper for basic_consume:

python-sensor/src/instana/instrumentation/pika.py

Lines 196 to 211 in ad0fb4b

	with tracer.start_as_current_span(
	"rabbitmq", span_context=parent_context
	) as span:
	try:
	_extract_consumer_tags(
	span, conn=instance.connection._impl, queue=queue
	)
	except Exception:
	logger.debug(
	"pika basic_consume_with_instana error:", exc_info=True
	)
	try:
	on_message_callback(channel, method, properties, body)
	except Exception as exc:
	span.record_exception(exc)

Here, the callback is executed inside the with statement.

Since the fix should be pretty straightforward, I'll create a PR for this issue and link it here once available.

Minimal, Complete, Verifiable, Example

My PR will include tests to demonstrate the behaviour

Python Version

3.12

Python Modules

N/A

Python Environment

N/A

[GSVarsha]

Hi @tobmi1, thank you for adding the test case as well!
It is indeed the wrong indentation that caused this issue.
We will review the PR from our side :)

[GSVarsha]

The PR is now merged to main. A new version with this fix can be expected by the end of this sprint (September 12).
Please install instana python package from github to have this fix in the mean time! ☺️

pip install git+https://github.com/instana/python-sensor

[tobmi1]

Hey @GSVarsha, thanks for having a look! I tried the python sensor from the latest main branch. Tracing through the RabbitMQ now works as expected and calls made by the consumer are now included in the trace as well.

I'll close the issue, thanks again for your support!

[GSVarsha]

Hello @tobmi1, just an update!
The latest release instana-3.8.2 has this fix :)