Skip to content

Search feature enhancements #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 2, 2025
Merged

Search feature enhancements #1841

merged 6 commits into from
Jun 2, 2025

Conversation

vijay2904
Copy link
Contributor

Features enhanced / added:

  1. Modified query logic to return all the matching snippets (not just the first N) using infinite scroll, in sets of 5.
  2. Added a short description to show the matching content with search keyword highlighted in bold.
  3. Added padding to the search icon in the nav menu.
  4. Added ctrl/cmd k to the end of the placeholder for users to know.

@vijay2904 vijay2904 mentioned this pull request May 30, 2025
Closed
2 tasks
nsarrazin
nsarrazin approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I modified a few things so we find the matched stem more reliably but it works well! Appreciate it. Will deploy 🚀

@nsarrazin nsarrazin merged commit 21dd968 into huggingface:main Jun 2, 2025
3 checks passed
@vijay2904
Copy link
Contributor Author

Thanks for accepting my changes. MongDB is not my strong forte >_<.

I was able to learn from your modifications. Thank you so much.

If you think my contribution is worth it, please assign the issue to me before closing.

  • By the way, I would like to write an article on my blog about this contribution with your permission.

maksym-work pushed a commit to siilats/chat-ui that referenced this pull request Jul 2, 2025
@vijay2904 @nsarrazin
Search feature enhancements (huggingface#1841)
7e91987 
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
@vijay2904 @nsarrazin
Search feature enhancements (huggingface#1841)
cb32b36 
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
@vijay2904 @nsarrazin
Search feature enhancements (huggingface#1841)
4aae0fd 
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
gary149 pushed a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
@vijay2904 @nsarrazin
Search feature enhancements (huggingface#1841)
7aaafe0 
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
gary149 pushed a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
@vijay2904 @nsarrazin
Search feature enhancements (huggingface#1841)
d985e52 
* Added infinite scrolling to search feature.

* Added code to highlight the search keyword in search description

* feat: improve description layout

* feat: improve search context finding

* fix: remove all debug bits

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nsarrazin nsarrazin nsarrazin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vijay2904 @nsarrazin