-
Notifications
You must be signed in to change notification settings - Fork 60
Support coloring vector features by an attribute containing a hex color code #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
40c2178
Implement new "Canonical" render type for vector layers
mfisher87 f3674b3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 22c4517
Extract generic function to dedup two very similar functions
mfisher87 647bd87
Lint! :bell:
mfisher87 caf90c2
Check feature properties before offering render type options
mfisher87 f4186d2
Check render types are supported before displaying them
mfisher87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
packages/base/src/dialogs/symbology/vector_layer/types/Canonical.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
import { IVectorLayer } from '@jupytergis/schema'; | ||
import { ExpressionValue } from 'ol/expr/expression'; | ||
import React, { useEffect, useRef, useState } from 'react'; | ||
import { getColorCodeFeatureAttributes } from '../../../../tools'; | ||
import { useGetProperties } from '../../hooks/useGetProperties'; | ||
import { ISymbologyDialogProps } from '../../symbologyDialog'; | ||
import ValueSelect from '../components/ValueSelect'; | ||
|
||
const Canonical = ({ | ||
model, | ||
state, | ||
okSignalPromise, | ||
cancel, | ||
layerId | ||
}: ISymbologyDialogProps) => { | ||
const selectedValueRef = useRef<string>(); | ||
|
||
const [selectedValue, setSelectedValue] = useState(''); | ||
const [attributes, setAttributes] = useState<Record<string, Set<string>>>({}); | ||
|
||
if (!layerId) { | ||
return; | ||
} | ||
const layer = model.getLayer(layerId); | ||
if (!layer?.parameters) { | ||
return; | ||
} | ||
const { featureProperties } = useGetProperties({ | ||
layerId, | ||
model: model | ||
}); | ||
|
||
useEffect(() => { | ||
okSignalPromise.promise.then(okSignal => { | ||
okSignal.connect(handleOk, this); | ||
}); | ||
|
||
return () => { | ||
okSignalPromise.promise.then(okSignal => { | ||
okSignal.disconnect(handleOk, this); | ||
}); | ||
}; | ||
}, [selectedValue]); | ||
|
||
useEffect(() => { | ||
// Filter for hex color code attributes | ||
const hexAttributes = getColorCodeFeatureAttributes(featureProperties); | ||
|
||
setAttributes(hexAttributes); | ||
|
||
const layerParams = layer.parameters as IVectorLayer; | ||
const value = | ||
layerParams.symbologyState?.value ?? Object.keys(hexAttributes)[0]; | ||
|
||
setSelectedValue(value); | ||
}, [featureProperties]); | ||
|
||
useEffect(() => { | ||
selectedValueRef.current = selectedValue; | ||
}, [selectedValue]); | ||
|
||
const handleOk = () => { | ||
if (!layer.parameters) { | ||
return; | ||
} | ||
|
||
const colorExpr: ExpressionValue[] = ['get', selectedValue]; | ||
const newStyle = { ...layer.parameters.color }; | ||
newStyle['fill-color'] = colorExpr; | ||
newStyle['stroke-color'] = colorExpr; | ||
newStyle['circle-fill-color'] = colorExpr; | ||
|
||
const symbologyState = { | ||
renderType: 'Canonical', | ||
value: selectedValueRef.current | ||
}; | ||
|
||
layer.parameters.symbologyState = symbologyState; | ||
layer.parameters.color = newStyle; | ||
if (layer.type === 'HeatmapLayer') { | ||
layer.type = 'VectorLayer'; | ||
} | ||
|
||
model.sharedModel.updateLayer(layerId, layer); | ||
cancel(); | ||
}; | ||
|
||
return ( | ||
<div className="jp-gis-layer-symbology-container"> | ||
<ValueSelect | ||
featureProperties={attributes} | ||
selectedValue={selectedValue} | ||
setSelectedValue={setSelectedValue} | ||
/> | ||
</div> | ||
); | ||
}; | ||
|
||
export default Canonical; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.