-
Notifications
You must be signed in to change notification settings - Fork 58
Support coloring vector features by an attribute containing a hex color code #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This render type uses a hex code in a vector attribute to define each feature's color.
for more information, see https://pre-commit.ci
Integration tests report: appsharing.space |
Is "canonical" a good name for this render type? I kind of hate it... maybe "Direct"? Other ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this Matt :)
Looks like this is still a WIP? does it work for any example?
For me it fails with:
canonical.mp4
packages/base/src/dialogs/symbology/vector_layer/VectorRendering.tsx
Outdated
Show resolved
Hide resolved
@arjxn-py Thanks for the review! Please try the undersea cables dataset listed in the PR description! That one contains a |
e6208e2
to
f4186d2
Compare
While I was in there, I also added checks for "graduated" and "categorized" render types; both require numeric values right now. In the future, we want to support non-numeric fields to be displayed with categorical rendering: #654 I also feel that we need to DRY and simplify this logic a little bit: #717 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Works Well, Thanks :)
Resolves #651
Description
This render type uses a hex code in a vector feature's attribute to define each feature's color.
For example, this undersea cables dataset includes a bunch of lines, each containing a
color
attribute which has a hex color code value.The new render type allows selecting from attributes with values that look like hex color codes, and using the color from that attribute to color the feature.
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--713.org.readthedocs.build/en/713/
💡 JupyterLite preview: https://jupytergis--713.org.readthedocs.build/en/713/lite