Fix ITs [ECR-3572] #1215
Merged
Fix ITs [ECR-3572] #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-timofeev
requested review from
MakarovS and
vitvakatu
and removed request for
MakarovS
7 tasks
1. Re-enabled ProofList compilation and tests to be able to use its Java
proxy; remove obsolete #getProof implementation.
2. Brought back AbstractService to provide convenience methods #getId
and #getName (how useful they are is an open question).
3. Fixed Integration tests.
1. NodeProxy test is removed, as Node is not accessible: ECR-3798
4. Migrated ITs to use fake-service. IT don’t need much from that service:
just that it has a single transaction that ITs can submit for execution.
Tests now run during verify phase so that the packaged service is available.
5. Enabled building testkit and integration-tests on CI; fixed some issues with that.
1. Some remain: testkit tests are broken when run in parallel: ECR-3797
dmitry-timofeev
force-pushed
the
fix-its
branch
from
bca4c61 to
68737dd
Compare
vitvakatu
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Re-enabled ProofList compilation and tests to be able to use its Java
proxy; remove obsolete #getProof implementation.
Brought back AbstractService to provide convenience methods #getId
and #getName (how useful they are is an open question).
Fixed Integration tests.
Migrated ITs to use fake-service. IT don’t need much from that service:
just that it has a single transaction that ITs can submit for execution.
Tests now run during verify phase so that the packaged service is available.
Enabled building testkit and integration-tests on CI; fixed some issues with that.
Added time oracle tests
See: https://jira.bf.local/browse/ECR-3572
Definition of Done