Update time service to dynamic services [ECR-3597] #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support multiple instances of time oracle. User must always specify the name of the time oracle they intend to use. - Use the runtime index to check if the service with the given name is active.
Enable checkstyle and fix style violations.
dmitry-timofeev
added
the
work-in-progress 👷♂️
|
The tests depend on the testkit, otherwise, it must be ready. |
vitvakatu
reviewed
Oct 1, 2019
exonum-java-binding/time-oracle/src/main/java/com/exonum/binding/time/TimeSchemaProxy.java
Outdated
Show resolved
Hide resolved
MakarovS
reviewed
Oct 2, 2019
| import com.exonum.binding.core.storage.indices.ProofMapIndexProxy; | ||
| import com.exonum.binding.messages.Runtime.InstanceSpec; | ||
|
|
||
| class RuntimeSchema { |
There was a problem hiding this comment.
Could you add some description?
exonum-java-binding/time-oracle/src/main/java/com/exonum/binding/time/TimeSchemaProxy.java
Outdated
Show resolved
Hide resolved
7 tasks
MakarovS
reviewed
Oct 7, 2019
exonum-java-binding/time-oracle/src/main/java/com/exonum/binding/time/TimeSchemaProxy.java
Outdated
Show resolved
Hide resolved
|
Merging as time oracle tests are with #1215 as a 🐔 and 🥚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update time service to dynamic services:
the name of the time oracle they intend to use.
is active.
See: https://jira.bf.local/browse/ECR-3597
Definition of Done