Skip to content

Bump min node/firefox/chrome version to ensure globalThis #25375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Bump min node/firefox/chrome version to ensure globalThis #25375

merged 1 commit into from
Sep 24, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 24, 2025

This change bumps the minimum versions of these engines so that we no longer need to support engines without globalThis.

kripken
kripken reviewed Sep 24, 2025
View reviewed changes
kripken
kripken reviewed Sep 24, 2025
View reviewed changes
kripken
kripken reviewed Sep 24, 2025
View reviewed changes
@sbc100 sbc100 force-pushed the node_update branch 4 times, most recently from 89714d4 to b8165d7 Compare September 24, 2025 18:22
@juj
Copy link
Collaborator

juj commented Sep 24, 2025

I vividly remember authoring a PR that unconditionally used globalThis, but then had to revert that due to some problem. I don't remember what it was though.

The caniuse numbers make it seem like it would be ubiquitous, and I do agree that bumping the min browser versions is ok to make this happen; I suppose our test suite should coax out what the issue was before, if one exists.

LGTM.

@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 24, 2025

I vividly remember authoring a PR that unconditionally used globalThis, but then had to revert that due to some problem. I don't remember what it was though.

Prior to this change we were testing on a version of node that didn't include globalThis.. do maybe it was that? Or maybe there were really old browser that you used to support. Hopefully no currently targeted browser has this issue. We can revert if needed.

@sbc100
Bump min node/firefox/chrome version to ensure globalThis
27c848b 
This change bumps the minimum versions of these engines so that we no
longer need to support engines without `globalThis`.
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 24, 2025

Maybe as a followup we can see of converting typeof foo == 'undefined' everywhere to !!globalThis.foo saves on code size.

@sbc100 sbc100 merged commit 764a88c into emscripten-core:main Sep 24, 2025
32 checks passed
@sbc100 sbc100 deleted the node_update branch September 24, 2025 22:04
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 24, 2025
@sbc100
Use globalThis with null chaining to save a little code size. NFC
4f64fdf 
Followup to emscripten-core#25375
@sbc100 sbc100 mentioned this pull request Sep 24, 2025
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 24, 2025
@sbc100
Use globalThis with null chaining to save a little code size. NFC
d49effe 
Followup to emscripten-core#25375
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 25, 2025
@sbc100
Bump min supported chrome version from 71 -> 73
dd78eba 
This means we no longer need to worry about engines without mutable
global support.

Followup to emscripten-core#25375.
@sbc100 sbc100 mentioned this pull request Sep 25, 2025
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 25, 2025
@sbc100
Bump min supported chrome version from 71 -> 73
0f21d20 
This means we no longer need to worry about engines without mutable
global support.

Followup to emscripten-core#25375.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 25, 2025
@sbc100
Bump min supported chrome version from 71 -> 73
6fe0fa5 
This means we no longer need to worry about engines without mutable
global support.

Followup to emscripten-core#25375.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 25, 2025
@sbc100
Bump min supported chrome version from 71 -> 73
7b2145a 
This means we no longer need to worry about engines without mutable
global support.

Followup to emscripten-core#25375.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Sep 25, 2025
@sbc100
Use globalThis with null chaining to save a little code size. NFC
ce61c9d 
Followup to emscripten-core#25375
sbc100 added a commit that referenced this pull request Sep 25, 2025
@sbc100
Bump min supported chrome version from 71 -> 73 (#25385)
3bad024 
This means we no longer need to worry about engines without mutable
global support.

Followup to #25375.
sbc100 added a commit that referenced this pull request Sep 25, 2025
@sbc100
Use globalThis with null chaining to save a little code size. NFC (#2…
ad53094 
…5381)

Followup to #25375
@sbc100 sbc100 mentioned this pull request Sep 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken left review comments

@juj juj juj approved these changes

@dschuff dschuff Awaiting requested review from dschuff

@brendandahl brendandahl Awaiting requested review from brendandahl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @juj @kripken