-
Notifications
You must be signed in to change notification settings - Fork 66
Add SBRPs to enable PVP flow for arcade repo #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mthalman - looks like there is a missing dependency, Newtonsoft.Json.9.0.1, coming from https://github.com/dotnet/source-build-reference-packages/pull/595/files#diff-feaa63e0b810c261fe8843e43b8aa7df8f8a5ec161b20411013f6a41b73740fc. Curious why the tooling missed this dependency. |
There are some additional packages that I missed that are being detected as prebuilts. I'll be adding them to this PR: Microsoft.CodeAnalysis.Analyzers.2.6.1 |
Ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the original PR comment to include all packages added. This will improve the traceability.
When attempting to enable PVP flow for the arcade repo, it exposed its dependencies on several packages that need to be provided in SBRP:
Manual changes needed to be made to the Microsoft.Extensions.Primitives generated code due to dotnet/sdk#31570.
Contributes to dotnet/source-build#3043