Skip to content

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Apr 3, 2023

When attempting to enable PVP flow for the arcade repo, it exposed its dependencies on several packages that need to be provided in SBRP:

  • Microsoft.CodeAnalysis.CSharp.2.9.0
    • New dependencies:
      • Microsoft.CodeAnalysis.Common.2.9.0
      • System.Diagnostics.StackTrace.4.3.0
      • System.Text.Encoding.CodePages.4.3.0
      • System.Threading.Tasks.Parallel.4.3.0
      • System.ValueTuple.4.3.0
      • System.Xml.XPath.4.3.0
      • System.Xml.XPath.XDocument.4.3.0
  • Microsoft.Extensions.DependencyInjection.6.0.0
    • New dependencies:
      • Microsoft.Extensions.DependencyInjection.Abstractions.6.0.0
  • Microsoft.Extensions.DependencyModel.2.1.0
    • New dependencies:
      • Microsoft.DotNet.PlatformAbstractions.2.1.0
  • Microsoft.Extensions.Logging.Console.6.0.0
    • New dependencies:
      • Microsoft.Extensions.Configuration.6.0.0
      • Microsoft.Extensions.Configuration.Abstractions.6.0.0
      • Microsoft.Extensions.Configuration.Binder.6.0.0
      • Microsoft.Extensions.Logging.6.0.0
      • Microsoft.Extensions.Logging.Abstractions.6.0.0
      • Microsoft.Extensions.Logging.Configuration.6.0.0
      • Microsoft.Extensions.Logging.Console.6.0.0
      • Microsoft.Extensions.Options.6.0.0
      • Microsoft.Extensions.Options.ConfigurationExtensions.6.0.0
      • Microsoft.Extensions.Primitives.6.0.0
      • System.Diagnostics.DiagnosticSource.6.0.0
  • System.IO.Packaging.4.5.0

Manual changes needed to be made to the Microsoft.Extensions.Primitives generated code due to dotnet/sdk#31570.

Contributes to dotnet/source-build#3043

@MichaelSimons
Copy link
Member

@mthalman - looks like there is a missing dependency, Newtonsoft.Json.9.0.1, coming from https://github.com/dotnet/source-build-reference-packages/pull/595/files#diff-feaa63e0b810c261fe8843e43b8aa7df8f8a5ec161b20411013f6a41b73740fc. Curious why the tooling missed this dependency.

@mthalman mthalman requested a review from MichaelSimons April 4, 2023 14:28
@mthalman
Copy link
Member Author

mthalman commented Apr 4, 2023

There are some additional packages that I missed that are being detected as prebuilts. I'll be adding them to this PR:

Microsoft.CodeAnalysis.Analyzers.2.6.1
Microsoft.CodeAnalysis.Common.2.9.0
Microsoft.CodeAnalysis.CSharp.2.9.0
System.Diagnostics.StackTrace.4.3.0
System.Private.Uri.4.3.2
System.Text.Encoding.CodePages.4.3.0
System.ValueTuple.4.3.0
System.Xml.XPath.4.3.0
System.Xml.XPath.XDocument.4.3.0

@mthalman
Copy link
Member Author

mthalman commented Apr 4, 2023

Ready for review now

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the original PR comment to include all packages added. This will improve the traceability.

@mthalman mthalman requested a review from MichaelSimons April 4, 2023 19:58
@MichaelSimons MichaelSimons enabled auto-merge (squash) April 4, 2023 20:02
@MichaelSimons MichaelSimons merged commit 3490baa into dotnet:main Apr 4, 2023
@mthalman mthalman deleted the arcade branch April 5, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants