-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Address warnings from MicrosoftCodeAnalysisVersion_LatestVS update #119077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Microsoft Code Analysis version to 4.14.0 and addresses compilation errors that arise from the upgrade. The changes include code modernization to use improved C# syntax patterns, removal of a deprecated type reference, and pragma warnings to suppress IDE suggestions for unused parameters.
- Updates MicrosoftCodeAnalysisVersion_LatestVS from 4.8.0 to 4.14.0
- Modernizes boolean comparisons to use direct negation instead of explicit comparisons with false/true
- Removes TypeNameParseOptions.cs from ILLink.RoslynAnalyzer project compilation
Reviewed Changes
Copilot reviewed 84 out of 84 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
eng/Versions.props | Updates Microsoft Code Analysis version to 4.14.0 |
src/tools/illink/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj | Removes TypeNameParseOptions.cs compilation and updates warning suppression |
src/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs | Modernizes boolean comparison syntax |
Multiple library files | Modernizes boolean comparison patterns throughout the codebase |
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexAssemblyCompiler.cs | Adds pragma warnings for unused parameters |
Comments suppressed due to low confidence (1)
Tagging subscribers to this area: @dotnet/area-meta |
Update MicrosoftCodeAnalysisVersion_LatestVS To 4.14.0 and fix build errors.I'm moving the version update into a separate change: #119116.
Remove warning suppressions and address errors from
MicrosoftCodeAnalysisVersion_LatestVS
update to 4.14.0.Fixes #119159