Skip to content

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 25, 2025

Update MicrosoftCodeAnalysisVersion_LatestVS To 4.14.0 and fix build errors.

I'm moving the version update into a separate change: #119116.

Remove warning suppressions and address errors from MicrosoftCodeAnalysisVersion_LatestVS update to 4.14.0.

Fixes #119159

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft Code Analysis version to 4.14.0 and addresses compilation errors that arise from the upgrade. The changes include code modernization to use improved C# syntax patterns, removal of a deprecated type reference, and pragma warnings to suppress IDE suggestions for unused parameters.

  • Updates MicrosoftCodeAnalysisVersion_LatestVS from 4.8.0 to 4.14.0
  • Modernizes boolean comparisons to use direct negation instead of explicit comparisons with false/true
  • Removes TypeNameParseOptions.cs from ILLink.RoslynAnalyzer project compilation

Reviewed Changes

Copilot reviewed 84 out of 84 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/Versions.props Updates Microsoft Code Analysis version to 4.14.0
src/tools/illink/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj Removes TypeNameParseOptions.cs compilation and updates warning suppression
src/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowVisitor.cs Modernizes boolean comparison syntax
Multiple library files Modernizes boolean comparison patterns throughout the codebase
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexAssemblyCompiler.cs Adds pragma warnings for unused parameters
Comments suppressed due to low confidence (1)

@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Aug 25, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@sbomer sbomer changed the title Update MicrosoftCodeAnalysisVersion_LatestVS Address warnings from MicrosoftCodeAnalysisVersion_LatestVS update Aug 26, 2025
@sbomer sbomer merged commit 762ed10 into dotnet:main Sep 16, 2025
164 checks passed
@xtqqczze
Copy link
Contributor

xtqqczze commented Sep 16, 2025

This change turned out to be the cause of later build failures, due to the removal of the IDE0060 suppression. The issue was fixed in #119772.

For context: build analysis was green prior to #119385, which introduced an IDE0060 violation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address new warnings from Microsoft.CodeAnalysis update
4 participants