Skip to content

adding GetAppDomainStoreData cDAC API #117633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2025
Merged

adding GetAppDomainStoreData cDAC API #117633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72049c3
adding GetAppDomainStoreData cDAC API
rcj1 Jul 14, 2025
3e4d128
renaming, restructuring and changing struct layout
rcj1 Jul 16, 2025
add577e
validation
rcj1 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ internal struct DacpThreadStoreData
public int fHostConfig; // Uses hosting flags defined above
};

internal struct DacpAppDomainStoreData
{
public ClrDataAddress sharedDomain;
public ClrDataAddress systemDomain;
public int DomainCount;
};
internal struct DacpThreadData
{
public int corThreadId;
Expand Down
31 changes: 30 additions & 1 deletion src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,36 @@ int ISOSDacInterface.GetAppDomainList(uint count, [In, MarshalUsing(CountElement
int ISOSDacInterface.GetAppDomainName(ClrDataAddress addr, uint count, char* name, uint* pNeeded)
=> _legacyImpl is not null ? _legacyImpl.GetAppDomainName(addr, count, name, pNeeded) : HResults.E_NOTIMPL;
int ISOSDacInterface.GetAppDomainStoreData(void* data)
=> _legacyImpl is not null ? _legacyImpl.GetAppDomainStoreData(data) : HResults.E_NOTIMPL;
{
DacpAppDomainStoreData* appDomainStoreData = (DacpAppDomainStoreData*)data;
int hr = HResults.S_OK;
try
{
appDomainStoreData->sharedDomain = 0;
TargetPointer systemDomainPtr = _target.ReadGlobalPointer(Constants.Globals.SystemDomain);
appDomainStoreData->systemDomain = _target.ReadPointer(systemDomainPtr).ToClrDataAddress(_target);
TargetPointer appDomainPtr = _target.ReadGlobalPointer(Constants.Globals.AppDomain);
appDomainStoreData->DomainCount = _target.ReadPointer(appDomainPtr) != 0 ? 1 : 0;
}
catch (System.Exception ex)
{
hr = ex.HResult;
}
#if DEBUG
{
if (_legacyImpl is not null)
{
DacpAppDomainStoreData dataLocal = default;
int hrLocal = _legacyImpl.GetAppDomainStoreData(&dataLocal);
Debug.Assert(hrLocal == hr, $"cDAC: {hr:x}, DAC: {hrLocal:x}");
Debug.Assert(appDomainStoreData->sharedDomain == dataLocal.sharedDomain, $"cDAC: {appDomainStoreData->sharedDomain:x}, DAC: {dataLocal.sharedDomain:x}");
Debug.Assert(appDomainStoreData->systemDomain == dataLocal.systemDomain, $"cDAC: {appDomainStoreData->systemDomain:x}, DAC: {dataLocal.systemDomain:x}");
Debug.Assert(appDomainStoreData->DomainCount == dataLocal.DomainCount, $"cDAC: {appDomainStoreData->DomainCount}, DAC: {dataLocal.DomainCount}");
}
}
#endif
return hr;
}
int ISOSDacInterface.GetApplicationBase(ClrDataAddress appDomain, int count, char* appBase, uint* pNeeded)
{
// Method is not supported on CoreCLR
Expand Down
Loading