-
Notifications
You must be signed in to change notification settings - Fork 5.2k
adding GetAppDomainStoreData cDAC API #117633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new cDAC implementation for retrieving AppDomain store data and adds the corresponding data structure to the SOS DAC interface.
- Implements
GetAppDomainStoreData
inSOSDacImpl
by reading global pointers for system and app domains. - Defines a new
DacpAppDomainStoreData
struct inISOSDacInterface
. - Adds DEBUG-only assertions to verify parity with the legacy DAC implementation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs | Added GetAppDomainStoreData method with pointer reads, exception handling, and debug cross-check |
src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs | Introduced DacpAppDomainStoreData struct for the new API |
Comments suppressed due to low confidence (3)
src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs:31
- The field name
DomainCount
uses PascalCase while the other fields use camelCase (sharedDomain
,systemDomain
). Consider renaming todomainCount
for consistency.
public ulong DomainCount;
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs:119
- There are no unit tests exercising the new
GetAppDomainStoreData
API. Consider adding tests under the existing test suite to validate pointer reads and returned values.
int ISOSDacInterface.GetAppDomainStoreData(void* data)
src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs:27
- The new
DacpAppDomainStoreData
struct lacks XML documentation. Add<summary>
comments for the struct and its fields to improve clarity for consumers.
internal struct DacpAppDomainStoreData
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
/ba-g build timeouts |
No description provided.