Skip to content

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 24, 2025

Backport of the current state of #63758

@wtgodbe wtgodbe requested a review from a team as a code owner September 24, 2025 18:46
@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 18:46
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 24, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a localization update that backports translations from another pull request, bringing updated Windows installer strings for the ASP.NET Core hosting components to the 10.0-rc2 release branch.

Key changes:

  • Updates installer UI strings across multiple languages (Spanish, Chinese, Turkish, Russian, Portuguese, Polish, Korean, Japanese, Italian, French, German, Czech, and Traditional Chinese)
  • Standardizes terminology and improves translation consistency
  • Adds new installer strings for additional UI elements and error states

Reviewed Changes

Copilot reviewed 39 out of 41 changed files in this pull request and generated no comments.

File Description
WindowsHostingBundle LCID thm.wxl files Updated installer UI strings for multiple languages with improved translations and additional strings
AspNetCoreModule-Setup LCID setupstrings.wxl files New localized setup strings for ASP.NET Core module installation across multiple languages
App.Runtime bundle theme LCID bundle.wxl files Updated bundle installer strings with improved translations and new UI elements
Comments suppressed due to low confidence (1)

src/Installers/Windows/WindowsHostingBundle/LCID/1040/thm.wxl:1

  • This Italian localization file contains English text instead of Italian translation for the HelpText string. This appears to be a localization error where the English text was copied instead of being translated.
<WixLocalization Culture="en-us" Language="1033" xmlns="http://wixtoolset.org/schemas/v4/wxl">

@wtgodbe wtgodbe merged commit bcb7be8 into release/10.0-rc2 Sep 24, 2025
24 of 28 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/Locrc2 branch September 24, 2025 20:12
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc2 milestone Sep 24, 2025
wtgodbe added a commit that referenced this pull request Sep 25, 2025
* Localization update (#63800)

* Load handler DLL with load dir on the path. (#63795)

Co-authored-by: Aditya Mandaleeka <[email protected]>

---------

Co-authored-by: William Godbe <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aditya Mandaleeka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant