Skip to content

Don't build Arm64 Windows installers in CI #63279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Don't build Arm64 Windows installers in CI #63279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67edf5e
Update ci.yml
wtgodbe Aug 15, 2025
19cd4b2
Update ci-public.yml
wtgodbe Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions .azure/pipelines/ci-public.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ variables:
value: /bl:artifacts/log/Release/Build.CodeSign.binlog
- name: WindowsInstallersLogArgs
value: /bl:artifacts/log/Release/Build.Installers.binlog
- name: WindowsArm64InstallersLogArgs
value: /bl:artifacts/log/Release/Build.Installers.Arm64.binlog
- name: _SignType
value: ''
- name: _InternalRuntimeDownloadArgs
Expand Down Expand Up @@ -205,29 +203,14 @@ stages:
-sign
-buildInstallers
-noBuildNative
/p:DotNetSignType=$(_SignType)
$(_BuildArgs)
$(_InternalRuntimeDownloadArgs)
$(WindowsInstallersLogArgs)
displayName: Build Installers

# Windows installers bundle and sharedfx msi for arm64
- script: ./eng/build.cmd
-ci
-prepareMachine
-noBuildRepoTasks
-arch arm64
-sign
-buildInstallers
-noBuildNative
-publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should -publish stay? It was only on included in the ARM64 step before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it has to go in the final build step of the job

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto /p:AssetManifestFileName and $(_PublishArgs)

/p:DotNetSignType=$(_SignType)
/p:AssetManifestFileName=aspnetcore-win.xml
$(_BuildArgs)
$(_PublishArgs)
$(_InternalRuntimeDownloadArgs)
$(WindowsArm64InstallersLogArgs)
displayName: Build ARM64 Installers
$(WindowsInstallersLogArgs)
displayName: Build Installers

artifacts:
- name: Windows_Logs_Attempt_$(System.JobAttempt)
Expand Down
23 changes: 2 additions & 21 deletions .azure/pipelines/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ variables:
value: /bl:artifacts/log/Release/Build.CodeSign.binlog
- name: WindowsInstallersLogArgs
value: /bl:artifacts/log/Release/Build.Installers.binlog
- name: WindowsArm64InstallersLogArgs
value: /bl:artifacts/log/Release/Build.Installers.Arm64.binlog
- name: _InternalRuntimeDownloadArgs
value: -RuntimeSourceFeed https://ci.dot.net/internal
-RuntimeSourceFeedKey $(dotnetbuilds-internal-container-read-token-base64)
Expand Down Expand Up @@ -255,33 +253,16 @@ extends:
-sign
-buildInstallers
-noBuildNative
/p:DotNetSignType=$(_SignType)
$(_BuildArgs)
$(_InternalRuntimeDownloadArgs)
$(WindowsInstallersLogArgs)
env:
MSBUILDUSESERVER: "1"
displayName: Build Installers

# Windows installers bundle and sharedfx msi for arm64
- script: ./eng/build.cmd
-ci
-prepareMachine
-noBuildRepoTasks
-arch arm64
-sign
-buildInstallers
-noBuildNative
-publish
/p:DotNetSignType=$(_SignType)
/p:AssetManifestFileName=aspnetcore-win.xml
$(_BuildArgs)
$(_PublishArgs)
$(_InternalRuntimeDownloadArgs)
$(WindowsArm64InstallersLogArgs)
$(WindowsInstallersLogArgs)
env:
MSBUILDUSESERVER: "1"
displayName: Build ARM64 Installers
displayName: Build Installers

artifacts:
- name: Windows_Logs_Attempt_$(System.JobAttempt)
Expand Down
Loading