Skip to content

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Aug 15, 2025

The Arm64 SharedFx/Targeting Pack Windows installers get built during the regular repo build now, so we don't need a separate build step just for them anymore. That step was doing exactly the same work as the regular Windows Installer step.

@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 18:32
@wtgodbe wtgodbe requested a review from a team as a code owner August 15, 2025 18:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dedicated ARM64 Windows installer build step from CI pipelines, as ARM64 installers are now built as part of the regular Windows installer build process. This eliminates duplicate build work and simplifies the CI pipeline.

  • Removed the separate ARM64 Windows installer build step from both CI pipelines
  • Consolidated the ARM64 installer build into the existing Windows installer step
  • Cleaned up associated variables and logging configurations for the removed build step

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.azure/pipelines/ci.yml Removed ARM64-specific installer build step and consolidated with main Windows installer build
.azure/pipelines/ci-public.yml Applied same ARM64 installer build consolidation to public CI pipeline

@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 15, 2025
-sign
-buildInstallers
-noBuildNative
-publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should -publish stay? It was only on included in the ARM64 step before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it has to go in the final build step of the job

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto /p:AssetManifestFileName and $(_PublishArgs)

@wtgodbe wtgodbe enabled auto-merge (squash) August 15, 2025 18:46
@wtgodbe wtgodbe disabled auto-merge August 15, 2025 19:37
@wtgodbe wtgodbe merged commit 045d245 into main Aug 15, 2025
27 of 30 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/dontbuildarminstallers branch August 15, 2025 19:37
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants