-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Don't build Arm64 Windows installers in CI #63279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the dedicated ARM64 Windows installer build step from CI pipelines, as ARM64 installers are now built as part of the regular Windows installer build process. This eliminates duplicate build work and simplifies the CI pipeline.
- Removed the separate ARM64 Windows installer build step from both CI pipelines
- Consolidated the ARM64 installer build into the existing Windows installer step
- Cleaned up associated variables and logging configurations for the removed build step
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.azure/pipelines/ci.yml | Removed ARM64-specific installer build step and consolidated with main Windows installer build |
.azure/pipelines/ci-public.yml | Applied same ARM64 installer build consolidation to public CI pipeline |
-sign | ||
-buildInstallers | ||
-noBuildNative | ||
-publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should -publish
stay? It was only on included in the ARM64 step before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it has to go in the final build step of the job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto /p:AssetManifestFileName
and $(_PublishArgs)
The Arm64 SharedFx/Targeting Pack Windows installers get built during the regular repo build now, so we don't need a separate build step just for them anymore. That step was doing exactly the same work as the regular Windows Installer step.