Skip to content

feat: improve Add performance #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022
Merged

feat: improve Add performance #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
584fded
test: fix benchmark
orisano Mar 28, 2022
2c59866
feat: improve Add performance
orisano Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,23 @@ func nrand(n int) []int {
return i
}

func benchAdd(b *testing.B, s Set[int]) {
nums := nrand(b.N)
func benchAdd(b *testing.B, n int, newSet func(...int) Set[int]) {
nums := nrand(n)
b.ResetTimer()
for _, v := range nums {
s.Add(v)
for i := 0; i < b.N; i++ {
s := newSet()
for _, v := range nums {
s.Add(v)
}
}
}

func BenchmarkAddSafe(b *testing.B) {
benchAdd(b, NewSet[int]())
benchAdd(b, 1000, NewSet[int])
}

func BenchmarkAddUnsafe(b *testing.B) {
benchAdd(b, NewThreadUnsafeSet[int]())
benchAdd(b, 1000, NewThreadUnsafeSet[int])
}

func benchRemove(b *testing.B, s Set[int]) {
Expand Down
8 changes: 2 additions & 6 deletions threadunsafe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,9 @@ func newThreadUnsafeSet[T comparable]() threadUnsafeSet[T] {
}

func (s *threadUnsafeSet[T]) Add(v T) bool {
_, found := (*s)[v]
if found {
return false //False if it existed already
}

prevLen := len(*s)
(*s)[v] = struct{}{}
return true
return prevLen != len(*s)
}

func (s *threadUnsafeSet[T]) Cardinality() int {
Expand Down