Skip to content

feat: improve Add performance #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2022
Merged

feat: improve Add performance #88

merged 2 commits into from
Mar 29, 2022

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Mar 28, 2022 

name         old time/op  new time/op  delta
AddSafe-8    96.6µs ± 1%  83.1µs ± 1%  -14.03%  (p=0.000 n=10+10)
AddUnsafe-8  78.4µs ± 1%  67.7µs ± 2%  -13.57%  (p=0.000 n=9+10)

@orisano orisano changed the title feat: improve add performance feat: improve Add performance Mar 28, 2022
@deckarep
Copy link
Owner

@orisano - this is a slick improvement and clever. I wouldn't have expected to realize such gains.

I suppose the overhead is in getting rid of the need to do a comparison/branch.

@deckarep deckarep merged commit 29bd72c into deckarep:main Mar 29, 2022
@jeffwidman jeffwidman mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orisano @deckarep