-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Switch stable rework #4861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmkraus
wants to merge
128
commits into
main
Choose a base branch
from
851-switch-stable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+439
−70
Open
Changes from all commits
Commits
Show all changes
128 commits
Select commit
Hold shift + click to select a range
54cab76
feat: enable in/valid state for switch
michaelmkraus 06fc979
feat(switch): unify validation styling and messages
michaelmkraus c93b20e
Merge branch 'main' into 851-switch-stable
michaelmkraus bddb8fb
feat(switch): configurable label position
michaelmkraus c7c72d6
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 275b0f0
feat(switch): add accent styling, same visual appearance as valid state
michaelmkraus 2a9efd4
feat(switch): a11y and validity style improvements
michaelmkraus 8c66eb9
Merge branch 'main' into 851-switch-stable
michaelmkraus 63ffa8e
feat(switch): fix linting errors
michaelmkraus c8b82ab
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 971d832
feat(switch): simplify SCSS mixin and remove unused imports
michaelmkraus d6b078f
feat(switch): removed aria-describedby
michaelmkraus 316cb67
auto update snapshots (#4944)
github-actions[bot] 7283c8a
test: updated snapshots
michaelmkraus 768828a
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 195181a
feat(switch): adapt label color for valid and invalid state
michaelmkraus 1aad439
feat(switch): remove aria-checked because it is not valid for inputs
michaelmkraus c442b26
feat(switch): update switch snapshots
michaelmkraus 0c573e6
feat(switch): remove emphasis property from switch
michaelmkraus a6f7441
Merge branch 'main' into 851-switch-stable
michaelmkraus 85b346a
feat(switch): update switch snapshots
michaelmkraus 9a0f9c2
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus c862521
feat(switch): remove example with emphasis from showcase
michaelmkraus 77ea68d
fix(docs): correct font path reference in migration documentation
michaelmkraus 0582f3b
feat(switch): update switch snapshots
michaelmkraus 82d09f2
feat(switch): update switch snapshots
michaelmkraus fbef1a0
feat(switch): update switch stencil-shocase snapshots
michaelmkraus b9ba796
feat(switch): update switch showcase snapshots
michaelmkraus 308f117
feat(switch): update switch angular and react showcase snapshots
michaelmkraus 8a60d90
test(switch): restore baseline visual snapshots from main
michaelmkraus d1dbdfe
fix(switch): ensure snapshot regeneration triggers on showcase test f…
michaelmkraus 415dd32
Merge branch 'main' into 851-switch-stable
michaelmkraus 91cea13
auto update snapshots (#4961)
github-actions[bot] 9d2b42b
test: updated snapshots
michaelmkraus 69cf19b
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 8eb2870
fix(switch): add missing regenerate snapshot scripts to angular and v…
michaelmkraus a610237
test: updated snapshots
michaelmkraus e287d3f
fix(switch): resolve snapshot regeneration for component tests
michaelmkraus 38f894a
Merge branch 'main' into 851-switch-stable
michaelmkraus 4592e19
Merge branch 'main' into 851-switch-stable
michaelmkraus b152d92
Merge branch 'main' into 851-switch-stable
mfranzke 217980b
fix(switch): remove unnecessary selector for switch label
michaelmkraus a0d4440
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus e8fa131
feat(switch): add aria attribute describedby to input of switch
michaelmkraus a8a9e88
refactor(switch): type ref as HTMLInputElement instead of any
michaelmkraus b7fd480
feat(switch): simplify validity mixin for switch
michaelmkraus a420631
Merge branch 'main' into 851-switch-stable
michaelmkraus 29521dd
fix(switch): use any type to prevent typescript conflicts at compilin…
michaelmkraus 986508f
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus d5c1545
test: updated snapshots
michaelmkraus 26d3b6d
test: updated snapshots
michaelmkraus 0c988f5
feat(switch): hand over valid and invalid message for angular and vue
michaelmkraus 85f11b9
test: updated snapshots
michaelmkraus 87b3ab7
test: updated snapshots
michaelmkraus e5333ca
chore(): adapt pipeline to handle has-failure correctly
michaelmkraus 099c5c2
chore(): readd always() to condition of commit-regenerate-snapshot
michaelmkraus f8c8a9f
Merge branch 'main' into 851-switch-stable
michaelmkraus 4ad160e
auto update snapshots (#4973)
github-actions[bot] 4ca6b3c
Merge branch 'main' into 851-switch-stable
michaelmkraus 8bc8e6e
chore(): increase threshold for snapshot validation
michaelmkraus 843ecb8
auto update snapshots (#4977)
github-actions[bot] 7e1f02f
chore(): increase threshold for react snapshot
michaelmkraus 2137748
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 114e4ab
Merge branch 'main' into 851-switch-stable
michaelmkraus c11a0b8
chore(): increase threshold for angular snapshot
michaelmkraus d963dd9
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus e6d9ca3
Merge branch 'main' into 851-switch-stable
michaelmkraus 678f9f8
Merge branch 'main' into 851-switch-stable
michaelmkraus 0e6a81c
Merge branch 'main' into 851-switch-stable
michaelmkraus 223fa1a
Merge branch 'main' into 851-switch-stable
michaelmkraus c9f7779
feat(): add leading and trailing icon for visual aid
michaelmkraus 667f69f
feat(): remove transition from icons when switching
michaelmkraus e2dd8c2
feat(): change label color for invalid state to correct value
michaelmkraus 5b1fba8
feat(): add example for showMessage property
michaelmkraus b68ef66
auto update snapshots (#5005)
github-actions[bot] 5e0c8bf
feat(switch): adapt hover and pressed color
michaelmkraus eddf837
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 99d984f
Merge branch 'main' into 851-switch-stable
michaelmkraus 93e24cc
feat(switch): wrap long labels correctly
michaelmkraus e4eae00
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus b5066fc
Merge branch 'main' into 851-switch-stable
michaelmkraus f17386c
Merge branch 'main' into 851-switch-stable
michaelmkraus 4fffe29
chore(switch): revert pipeline changes
michaelmkraus 46e1608
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus c6e04a3
chore(switch): revert unused scripts
michaelmkraus 6238862
chore(switch): revert unused scripts
michaelmkraus 9f7e800
auto update snapshots (#5017)
github-actions[bot] f50011d
chore(switch): remove unnecessary comments
michaelmkraus 61e849c
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 03b9666
auto update snapshots (#5018)
github-actions[bot] 72af3da
feat(switch): adapt hover-color when no more hovering and adapt messa…
michaelmkraus 97176af
feat(switch): show default icon for messages
michaelmkraus d99cf60
Merge branch 'main' into 851-switch-stable
michaelmkraus b78d50d
feat(switch): show default icon for messages
michaelmkraus 36cb89f
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus dffa666
chore: add db-theme, db-theme-fonts and db-theme-icons to package.jso…
michaelmkraus 9bf2b2b
chore: synchronize package-lock
michaelmkraus d3706a1
auto update snapshots (#5033)
github-actions[bot] dd000db
chore: adapt label of show message showcase
michaelmkraus c9e5aed
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 7d38381
auto update snapshots (#5035)
github-actions[bot] d2d52ad
feat(switch): remove hover-color of switch when leaving control
michaelmkraus 9ac3e2e
Merge remote-tracking branch 'origin/main' into 851-switch-stable
michaelmkraus 0f94bb5
Merge branch 'main' into 851-switch-stable
michaelmkraus 74ac47f
feat(switch): pass showMessage for vue and angular
michaelmkraus 439d041
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus daecd8f
Merge branch 'main' into 851-switch-stable
michaelmkraus 54c6d22
Merge branch 'main' into 851-switch-stable
michaelmkraus ce71a8c
Merge branch 'main' into 851-switch-stable
michaelmkraus e511c7d
chore(switch): remove accent showcase
michaelmkraus b81a9e6
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 7d6e57c
Merge branch 'main' into 851-switch-stable
michaelmkraus a01c3c5
chore(switch): set background when not checked but focused
michaelmkraus 71316ee
auto update snapshots (#5061)
github-actions[bot] e00b00c
Merge branch 'main' into 851-switch-stable
michaelmkraus e62fbbe
chore(switch): add fonts and icons dependencies to patternhub
michaelmkraus 77be3aa
auto update snapshots (#5071)
github-actions[bot] 9466958
feat(switch): adapt pressed unchecked color
michaelmkraus 9679c1a
auto update snapshots (#5072)
github-actions[bot] c339219
feat(switch): show asterisk behind label if switch is required
michaelmkraus 24b9ea7
fix(switch): adapt margin of small labels for angular and vue
michaelmkraus 3228821
Merge branch 'main' into 851-switch-stable
michaelmkraus 203c1d3
Merge branch 'main' into 851-switch-stable
michaelmkraus 6580617
auto update snapshots (#5099)
github-actions[bot] 37265c7
feat(switch): do not add label-position attribute if showLabel is
michaelmkraus b8e5c05
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
michaelmkraus 806bda9
auto update snapshots (#5102)
github-actions[bot] 7e5d88c
Merge branch 'main' into 851-switch-stable
michaelmkraus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+1.77 KB
(110%)
__snapshots__/switch/patternhub/switch-properties-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+17.7 KB
(120%)
...ontrast/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+19.7 KB
(120%)
...hromium/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+33.7 KB
(120%)
...firefox/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8.81 KB
(110%)
...-chrome/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12.1 KB
(110%)
...-safari/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+21.8 KB
(120%)
.../webkit/DBSwitch-should-match-screenshot-1/DBSwitch-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.