Skip to content

feat: Switch stable rework #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 128 commits into
base: main
Choose a base branch
from
Open

feat: Switch stable rework #4861

wants to merge 128 commits into from

Conversation

michaelmkraus
Copy link
Contributor

@michaelmkraus michaelmkraus commented Aug 28, 2025 •
edited
Loading

Proposed changes

  • enable in/valid state for switch
  • add accent styling
  • configurable label position
  • remove emphasis property from switch

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

closes https://github.com/db-ux-design-system/core-team/issues/851

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7e5d88c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 📺showcases Changes to 1-n showcases 🏘components labels Aug 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/851-switch-stable

@michaelmkraus michaelmkraus self-assigned this Aug 28, 2025
@michaelmkraus michaelmkraus marked this pull request as draft August 28, 2025 11:30
@michaelmkraus michaelmkraus moved this to 🕋 In progress in UX Engineering Team Backlog Aug 28, 2025
michaelmkraus and others added 19 commits September 4, 2025 16:14
@michaelmkraus
feat(switch): unify validation styling and messages
06fc979
@michaelmkraus
Merge branch 'main' into 851-switch-stable
c93b20e
@michaelmkraus
feat(switch): configurable label position
bddb8fb
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
c7c72d6 
…ch-stable
@michaelmkraus
feat(switch): add accent styling, same visual appearance as valid state
275b0f0
@michaelmkraus
feat(switch): a11y and validity style improvements
2a9efd4
@michaelmkraus
Merge branch 'main' into 851-switch-stable
8c66eb9
@michaelmkraus
feat(switch): fix linting errors
63ffa8e
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
c8b82ab 
…ch-stable
@michaelmkraus
feat(switch): simplify SCSS mixin and remove unused imports
971d832
@michaelmkraus
feat(switch): removed aria-describedby
d6b078f
@github-actions
auto update snapshots (#4944)
316cb67 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
test: updated snapshots
7283c8a
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
768828a 
…ch-stable
@michaelmkraus
feat(switch): adapt label color for valid and invalid state
195181a
@michaelmkraus
feat(switch): remove aria-checked because it is not valid for inputs
1aad439
@michaelmkraus
feat(switch): update switch snapshots
c442b26
@michaelmkraus
feat(switch): remove emphasis property from switch
0c573e6
@michaelmkraus
Merge branch 'main' into 851-switch-stable
a6f7441
michaelmkraus and others added 30 commits September 23, 2025 15:47
@michaelmkraus
chore: adapt label of show message showcase
dd000db
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
c9e5aed 
…ch-stable
@github-actions
auto update snapshots (#5035)
7d38381 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
feat(switch): remove hover-color of switch when leaving control
d2d52ad
@michaelmkraus
Merge remote-tracking branch 'origin/main' into 851-switch-stable
9ac3e2e 
# Conflicts:
#	package-lock.json
@michaelmkraus
Merge branch 'main' into 851-switch-stable
0f94bb5
@michaelmkraus
feat(switch): pass showMessage for vue and angular
74ac47f
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
439d041 
…ch-stable
@michaelmkraus
Merge branch 'main' into 851-switch-stable
daecd8f 
# Conflicts:
#	__snapshots__/brand/patternhub/brand-overview-should-match-screenshot.png
#	__snapshots__/header/patternhub/header-overview-should-match-screenshot.png
@michaelmkraus
Merge branch 'main' into 851-switch-stable
54c6d22
@michaelmkraus
Merge branch 'main' into 851-switch-stable
ce71a8c
@michaelmkraus
chore(switch): remove accent showcase
e511c7d
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
b81a9e6 
…ch-stable
@michaelmkraus
Merge branch 'main' into 851-switch-stable
7d6e57c
@michaelmkraus
chore(switch): set background when not checked but focused
a01c3c5
@github-actions
auto update snapshots (#5061)
71316ee 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
Merge branch 'main' into 851-switch-stable
e00b00c
@michaelmkraus
chore(switch): add fonts and icons dependencies to patternhub
e62fbbe
@github-actions
auto update snapshots (#5071)
77be3aa 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
feat(switch): adapt pressed unchecked color
9466958
@github-actions
auto update snapshots (#5072)
9679c1a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
feat(switch): show asterisk behind label if switch is required
c339219
@michaelmkraus
fix(switch): adapt margin of small labels for angular and vue
24b9ea7
@michaelmkraus
Merge branch 'main' into 851-switch-stable
3228821
@michaelmkraus
Merge branch 'main' into 851-switch-stable
203c1d3
@github-actions
auto update snapshots (#5099)
6580617 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
feat(switch): do not add label-position attribute if showLabel is
37265c7
@michaelmkraus
Merge remote-tracking branch 'origin/851-switch-stable' into 851-swit…
b8e5c05 
…ch-stable
@github-actions
auto update snapshots (#5102)
806bda9 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelmkraus
Merge branch 'main' into 851-switch-stable
7e5d88c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahbrng sarahbrng sarahbrng left review comments

@mfranzke mfranzke Awaiting requested review from mfranzke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏘components 📺showcases Changes to 1-n showcases
Projects
Roadmap
Status: No status
UX Engineering Team Backlog
Status: 👀 Actively In Review
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmkraus @mfranzke @sarahbrng