Skip to content

Update versions of llama.cpp and whisper.cpp #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Update versions of llama.cpp and whisper.cpp #1874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions container-images/scripts/build_llama_and_whisper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ configure_common_flags() {
}

clone_and_build_whisper_cpp() {
local DEFAULT_WHISPER_COMMIT="d0a9d8c7f8f7b91c51d77bbaa394b915f79cde6b"
local DEFAULT_WHISPER_COMMIT="7745fcf32846006128f16de429cfe1677c963b30"
local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$DEFAULT_WHISPER_COMMIT}"
Comment on lines +238 to 239
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To align with shell scripting best practices (like the Google Shell Style Guide) and maintain consistency with other local variables in this script, it's recommended to use snake_case for local variable names. I suggest renaming DEFAULT_WHISPER_COMMIT.1

Suggested change
local DEFAULT_WHISPER_COMMIT="7745fcf32846006128f16de429cfe1677c963b30"
local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$DEFAULT_WHISPER_COMMIT}"
local default_whisper_commit="7745fcf32846006128f16de429cfe1677c963b30"
local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$default_whisper_commit}"

Style Guide References

Footnotes

  1. The Google Shell Style Guide recommends using lowercase with underscores for local variable names (lower_case_with_underscores). This improves readability and distinguishes them from global constants. ↩

local whisper_flags=("${common_flags[@]}")
whisper_flags+=("-DBUILD_SHARED_LIBS=OFF")
Expand All @@ -254,7 +254,7 @@ clone_and_build_whisper_cpp() {
}

clone_and_build_llama_cpp() {
local DEFAULT_LLAMA_CPP_COMMIT=1d72c841888b9450916bdd5a9b3274da380f5b36
local DEFAULT_LLAMA_CPP_COMMIT=9961d244f2df6baf40af2f1ddc0927f8d91578c8
local llama_cpp_commit="${LLAMA_CPP_PULL_REF:-$DEFAULT_LLAMA_CPP_COMMIT}"
local install_prefix
install_prefix=$(set_install_prefix)
Expand Down
Loading