Update versions of llama.cpp and whisper.cpp #1874

rhatdan · 2025-08-28T12:50:52Z

Summary by Sourcery

Update default commit references for llama.cpp and whisper.cpp in the build script

Chores:

Bump default whisper.cpp commit to 7745fcf32846006128f16de429cfe1677c963b30
Bump default llama.cpp commit to 55042b3692cb1467c9ee15c62c4a9fbf180f89e3

sourcery-ai · 2025-08-28T12:51:03Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the default submodule commit references for whisper.cpp and llama.cpp in the build script to newer revisions.

File-Level Changes

Change	Details	Files
Bump default commit for whisper.cpp	Replace old DEFAULT_WHISPER_COMMIT SHA with the new SHA	`container-images/scripts/build_llama_and_whisper.sh`
Bump default commit for llama.cpp	Replace old DEFAULT_LLAMA_CPP_COMMIT SHA with the new SHA	`container-images/scripts/build_llama_and_whisper.sh`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist

Summary of Changes

Hello @rhatdan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default commit hashes for the llama.cpp and whisper.cpp projects within the build_llama_and_whisper.sh script. This ensures that container images built using this script will utilize more recent versions of these critical machine learning libraries, incorporating the latest features, bug fixes, and performance improvements.

Highlights

whisper.cpp version update: Updated the default commit hash for whisper.cpp from d0a9d8c7f8f7b91c51d77bbaa394b915f79cde6b to 7745fcf32846006128f16de429cfe1677c963b30 in the build script.
llama.cpp version update: Updated the default commit hash for llama.cpp from 1d72c841888b9450916bdd5a9b3274da380f5b36 to 55042b3692cb1467c9ee15c62c4a9fbf180f89e3 in the build script.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist

Code Review

This pull request updates the default commit hashes for whisper.cpp and llama.cpp to newer versions. The changes are straightforward. My review includes suggestions to improve variable naming conventions for better consistency and adherence to shell scripting best practices, which will improve the overall maintainability of the script.

gemini-code-assist · 2025-08-28T12:52:10Z

container-images/scripts/build_llama_and_whisper.sh

+  local DEFAULT_WHISPER_COMMIT="7745fcf32846006128f16de429cfe1677c963b30"
  local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$DEFAULT_WHISPER_COMMIT}"


To align with shell scripting best practices (like the Google Shell Style Guide) and maintain consistency with other local variables in this script, it's recommended to use snake_case for local variable names. I suggest renaming DEFAULT_WHISPER_COMMIT.¹

Suggested change

local DEFAULT_WHISPER_COMMIT="7745fcf32846006128f16de429cfe1677c963b30"

local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$DEFAULT_WHISPER_COMMIT}"

local default_whisper_commit="7745fcf32846006128f16de429cfe1677c963b30"

local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$default_whisper_commit}"

Style Guide References

Footnotes

The Google Shell Style Guide recommends using lowercase with underscores for local variable names (lower_case_with_underscores). This improves readability and distinguishes them from global constants. ↩

gemini-code-assist · 2025-08-28T12:52:11Z

container-images/scripts/build_llama_and_whisper.sh

+  local DEFAULT_LLAMA_CPP_COMMIT=55042b3692cb1467c9ee15c62c4a9fbf180f89e3
  local llama_cpp_commit="${LLAMA_CPP_PULL_REF:-$DEFAULT_LLAMA_CPP_COMMIT}"


Similar to the other comment, this local variable should be renamed to snake_case for consistency and to follow common shell scripting style conventions.¹

Suggested change

local DEFAULT_LLAMA_CPP_COMMIT=55042b3692cb1467c9ee15c62c4a9fbf180f89e3

local llama_cpp_commit="${LLAMA_CPP_PULL_REF:-$DEFAULT_LLAMA_CPP_COMMIT}"

local default_llama_cpp_commit=55042b3692cb1467c9ee15c62c4a9fbf180f89e3

local llama_cpp_commit="${LLAMA_CPP_PULL_REF:-$default_llama_cpp_commit}"

Style Guide References

Footnotes

The Google Shell Style Guide recommends using lowercase with underscores for local variable names (lower_case_with_underscores). This improves readability and distinguishes them from global constants. ↩

engelmi · 2025-09-01T09:16:54Z

/packit rebuild-failed

Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan · 2025-09-04T20:19:11Z

Merging.

rhatdan requested review from bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver and engelmi as code owners August 28, 2025 12:50

gemini-code-assist bot reviewed Aug 28, 2025

View reviewed changes

sourcery-ai bot approved these changes Aug 28, 2025

View reviewed changes

gemini-code-assist bot reviewed Aug 28, 2025

View reviewed changes

rhatdan force-pushed the llama.cpp branch from 5f8911d to 39b812b Compare September 2, 2025 13:14

Update versions of llama.cpp and whisper.cpp

60ab8af

Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the llama.cpp branch from 39b812b to 60ab8af Compare September 4, 2025 11:28

rhatdan merged commit 3152564 into containers:main Sep 4, 2025
62 of 69 checks passed

This was referenced Sep 8, 2025

System test failure: run smollm with prompt #1908

Closed

Extended inspect command by --get option with auto-complete #1889

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update versions of llama.cpp and whisper.cpp #1874

Update versions of llama.cpp and whisper.cpp #1874

Uh oh!

rhatdan commented Aug 28, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Aug 28, 2025 •

edited

Loading

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

sourcery-ai bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 28, 2025

Uh oh!

gemini-code-assist bot Aug 28, 2025

Uh oh!

engelmi commented Sep 1, 2025

Uh oh!

rhatdan commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

		local DEFAULT_WHISPER_COMMIT="7745fcf32846006128f16de429cfe1677c963b30"
		local whisper_cpp_commit="${WHISPER_CPP_PULL_REF:-$DEFAULT_WHISPER_COMMIT}"

		local DEFAULT_LLAMA_CPP_COMMIT=55042b3692cb1467c9ee15c62c4a9fbf180f89e3
		local llama_cpp_commit="${LLAMA_CPP_PULL_REF:-$DEFAULT_LLAMA_CPP_COMMIT}"

Update versions of llama.cpp and whisper.cpp #1874

Update versions of llama.cpp and whisper.cpp #1874

Uh oh!

Conversation

rhatdan commented Aug 28, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 28, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

gemini-code-assist bot Aug 28, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

engelmi commented Sep 1, 2025

Uh oh!

rhatdan commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

rhatdan commented Aug 28, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Aug 28, 2025 •

edited

Loading