Skip to content

fix: Update UnprocessedRequest to match actual data #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

fix: Update UnprocessedRequest to match actual data #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d46e2b
Update `UnprocessedRequest` to match actual data. Add test.
Pijukatel Apr 16, 2025
6ebc9ff
Make url mandatory again
Pijukatel Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/storage_clients/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class UnprocessedRequest(BaseModel):

model_config = ConfigDict(populate_by_name=True)

unique_key: Annotated[str, Field(alias='requestUniqueKey')]
unique_key: Annotated[str, Field(alias='uniqueKey')]
url: Annotated[str, BeforeValidator(validate_http_url), Field()]
method: Annotated[HttpMethod | None, Field()] = None

Expand Down
19 changes: 19 additions & 0 deletions tests/unit/storage_clients/_memory/test_memory_storage_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from crawlee._consts import METADATA_FILENAME
from crawlee.configuration import Configuration
from crawlee.storage_clients import MemoryStorageClient
from crawlee.storage_clients.models import BatchRequestsOperationResponse


async def test_write_metadata(tmp_path: Path) -> None:
Expand Down Expand Up @@ -267,3 +268,21 @@ async def test_parametrized_storage_path_overrides_env_var() -> None:
Configuration(crawlee_storage_dir='./parametrized_storage_dir'), # type: ignore[call-arg]
)
assert ms.storage_dir == './parametrized_storage_dir'


async def test_batch_requests_operation_response() -> None:
"""Test that `BatchRequestsOperationResponse` creation from example responses."""
process_request = {
'requestId': 'EAaArVRs5qV39C9',
'uniqueKey': 'https://example.com',
'wasAlreadyHandled': False,
'wasAlreadyPresent': True,
}
unprocess_request_full = {'uniqueKey': 'https://example2.com', 'method': 'GET', 'url': 'https://example2.com'}
unprocess_request_minimal = {'uniqueKey': 'https://example3.com', 'url': 'https://example3.com'}
BatchRequestsOperationResponse.model_validate(
{
'processedRequests': [process_request],
'unprocessedRequests': [unprocess_request_full, unprocess_request_minimal],
}
)
Loading