fix: Update UnprocessedRequest to match actual data
#1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
|
Not part of this issue, but |
Pijukatel
changed the title
UnprocessedRequest to match actual data. Add test.UnprocessedRequest to match actual data
B4nan
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/unit/storage_clients/_memory/test_memory_storage_client.py:283
- Consider capturing the output of model_validate and asserting that the resulting object's fields match the expected values, rather than only relying on successful validation.
BatchRequestsOperationResponse.model_validate({
UnprocessedRequest to match actual dataUnprocessedRequest to match actual data
janbuchar
approved these changes
Apr 22, 2025
Mantisus
pushed a commit
to Mantisus/crawlee-python
that referenced
this pull request
Apr 24, 2025
### Description Update `UnprocessedRequest` to match actual data. Add test. ### Issues - Closes: apify#1150
Mantisus
pushed a commit
to Mantisus/crawlee-python
that referenced
this pull request
Apr 24, 2025
### Description Update `UnprocessedRequest` to match actual data. Add test. ### Issues - Closes: apify#1150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
UnprocessedRequestto match actual data.Add test.
Issues