Skip to content

feat: add widget.mount(), use it in demo, add branding to DOM #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 29, 2025
Merged

feat: add widget.mount(), use it in demo, add branding to DOM #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
139783c
wip
teallarson Apr 29, 2025
bd3e1b8
branding works too albeit not ideal
teallarson Apr 29, 2025
367694a
fix test
teallarson Apr 29, 2025
0bc6d4c
move demo to use `mount()` as shown in the docs
teallarson Apr 29, 2025
3ec4b49
fix tests and demo to use mount()
teallarson Apr 29, 2025
ac0b823
add mount method and add branding to DOM
teallarson Apr 29, 2025
b8076f2
🧹
teallarson Apr 29, 2025
47951ff
cleanup
teallarson Apr 29, 2025
531260e
don't allow token to be optional
teallarson Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion demo/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ CLIENT_ID=
CLIENT_SECRET=
ORGANIZATION_ID=
WORKSPACE_ID=
ALLOWED_ORIGIN=
BASE_URL=
```

Expand Down
3 changes: 3 additions & 0 deletions demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<title>Airbyte Embedded Widget</title>
</head>
<body>
<h1>Airbyte Embedded Widget</h1>
<div id="widget-container"></div>

<script type="module">
Expand Down Expand Up @@ -36,6 +37,8 @@
token: data.token,
onEvent: widgetResultCallback,
});

widget.mount("#widget-container");
} catch (err) {
console.error("Failed to load widget:", err);
}
Expand Down
13 changes: 9 additions & 4 deletions demo/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,17 @@ const AIRBYTE_ACCESS_TOKEN_URL = `${BASE_URL}/v1/applications/token`;
const CLIENT_ID = process.env.CLIENT_ID;
const CLIENT_SECRET = process.env.CLIENT_SECRET;
const WORKSPACE_ID = process.env.WORKSPACE_ID;
const ORGANIZATION_ID = process.env.ORGANIZATION_ID;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used

const ALLOWED_ORIGIN = process.env.ALLOWED_ORIGIN || "http://localhost:3000";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be inferred!


// GET /api/widget → fetch widget token and return it
app.get("/api/widget_token", async (req, res) => {
try {
// Determine the allowed origin from the request
const origin =
req.headers.origin ||
req.headers.referer?.replace(/\/$/, "") ||
process.env.ALLOWED_ORIGIN ||
"http://localhost:3000";

const access_token_body = JSON.stringify({
client_id: CLIENT_ID,
client_secret: CLIENT_SECRET,
Expand Down Expand Up @@ -66,8 +71,7 @@ app.get("/api/widget_token", async (req, res) => {
},
body: JSON.stringify({
workspaceId: WORKSPACE_ID,
organizationId: ORGANIZATION_ID,
allowedOrigin: ALLOWED_ORIGIN,
allowedOrigin: origin,
}),
});

Expand All @@ -78,6 +82,7 @@ app.get("/api/widget_token", async (req, res) => {
}

const widget_token = await widget_token_response.text();

res.json({ token: widget_token });
} catch (err) {
console.error("Unexpected error:", err);
Expand Down
Loading
Loading