feat: add widget.mount(), use it in demo, add branding to DOM #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
commented
Apr 29, 2025
| const CLIENT_ID = process.env.CLIENT_ID; | ||
| const CLIENT_SECRET = process.env.CLIENT_SECRET; | ||
| const WORKSPACE_ID = process.env.WORKSPACE_ID; | ||
| const ORGANIZATION_ID = process.env.ORGANIZATION_ID; |
teallarson
commented
Apr 29, 2025
| const CLIENT_SECRET = process.env.CLIENT_SECRET; | ||
| const WORKSPACE_ID = process.env.WORKSPACE_ID; | ||
| const ORGANIZATION_ID = process.env.ORGANIZATION_ID; | ||
| const ALLOWED_ORIGIN = process.env.ALLOWED_ORIGIN || "http://localhost:3000"; |
There was a problem hiding this comment.
can be inferred!
teallarson
commented
Apr 29, 2025
There was a problem hiding this comment.
I couldn't hang with the very random TS that was going on in here. I've pulled out an named a number of functions and styles so this is more readable. That's the bulk of the changes here. Technically should have been a separate refactor PR probably.
girarda
approved these changes
Apr 29, 2025
teallarson
added a commit
that referenced
this pull request
Apr 30, 2025
teallarson
added a commit
that referenced
this pull request
Apr 30, 2025
teallarson
added a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/12663
Adds Airbyte Embedded branding to the backdrop as seen in Figma
I also noticed while working on adding the branding that our docs say we should have a
widget.mount()method that attaches it to the correct DOM element. We weren't using this, though. Now we are!Some of the commits in this history are from working on adding a
devproject in here. I will split that into a separate PR, though.Last but not least: the updates to the lockfile is a fix from my last PR.
NOTE: there isn't a great way to run the widget locally to confirm these changes... which is why I also have a PR open to add a
devNextjs app that makes that possible #16