fix: Height of modal underlay is incorrect when the body has height: 100% #8958
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Oct 2, 2025
| let scrollingElement = isScrollable(document.body) ? document.body : document.scrollingElement || document.documentElement; | ||
| // Prevent Firefox from adding scrollbars when the page has a fractional height. | ||
| let fractionalHeightDifference = scrollingElement.clientHeight - scrollingElement.getBoundingClientRect().height; | ||
| pageHeight = scrollingElement.scrollHeight - fractionalHeightDifference; |
There was a problem hiding this comment.
I don't think there's another way to get the scrollHeight but not rounded?
|
Build successful! 🎉 |
snowystinger
reviewed
Oct 2, 2025
This reverts commit 5420894.
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Oct 2, 2025
reidbarber
previously approved these changes
Oct 2, 2025
This reverts commit 21740c3.
|
grabbing a build for the apps with the last couple of changes just in case |
This reverts commit 42cb451.
|
Build successful! 🎉 |
LFDanLu
approved these changes
Oct 2, 2025
|
https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1051 |
dannify
approved these changes
Oct 2, 2025
reidbarber
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug that occurs in our CRA example app, where the body has
height: 100%. If you open a modal, the underlay is not visible. We need to use thescrollHeightinstead of theclientHeight/ bounding client rect.Test instructions: