-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: Lockfiles for all apps #8940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 5bff9d5.
|
||
starter: | ||
cd starters/docs && yarn --no-immutable && yarn tsc | ||
cd starters/docs && yarn --no-immutable && yarn up react-aria-components && yarn tsc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this forces the update from the version provided by the root workspace, to the latest tag on verdaccio. I'm not sure why there is no way to override this yarn behaviour and not look at the root workspace at all, but this appears to be the case currently. I think due to yarnpkg/yarn#4099
Build successful! 🎉 |
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going off of https://reactspectrum.blob.core.windows.net/reactspectrum/c73e1ccf5884a88c94610a91fec281495ff69e89/verdaccio/rsp-cra-18/index.html which is the CRA app from the last verdaccio comment in this PR, it seems like it might be pulling latest off of npm rather than verdaccio still? It doesn't exhibit the bug that #8958 fixed but if it was pulling from the verdaccio published package it should exhibit the bug no? Do we need to update the verdaccio.sh/each project's specific one to force an upgrade of the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, yep
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:createLeafComponent-createLeafComponent <E extends Element, P extends {}> {
- CollectionNodeClass: {}<any> | string
- render: (P, ForwardedRef<E>, any) => ReactElement | null
- returnVal: undefined
-} /react-aria-components:createBranchComponent-createBranchComponent <E extends Element, P extends {
- children?: any
-}, T extends {}> {
- CollectionNodeClass: {}<any> | string
- render: (P, ForwardedRef<E>, Node<T>) => ReactElement | null
- useChildren: (P) => ReactNode
- returnVal: undefined
-} /react-aria-components:CollectionBuilder-CollectionBuilder <C extends BaseCollection<{}>> {
- children: (BaseCollection<{}>) => ReactNode
- content: ReactNode
- createCollection?: () => BaseCollection<{}>
-} /react-aria-components:UNSTABLE_createLeafComponent+UNSTABLE_createLeafComponent <E extends Element, P extends {}> {
+ CollectionNodeClass: {}<any> | string
+ render: (P, ForwardedRef<E>, any) => ReactElement | null
+ returnVal: undefined
+} /react-aria-components:UNSTABLE_createBranchComponent+UNSTABLE_createBranchComponent <E extends Element, P extends {
+ children?: any
+}, T extends {}> {
+ CollectionNodeClass: {}<any> | string
+ render: (P, ForwardedRef<E>, Node<T>) => ReactElement | null
+ useChildren: (P) => ReactNode
+ returnVal: undefined
+} /react-aria-components:UNSTABLE_CollectionBuilder+UNSTABLE_CollectionBuilder <C extends BaseCollection<{}>> {
+ children: (BaseCollection<{}>) => ReactNode
+ content: ReactNode
+ createCollection?: () => BaseCollection<{}>
+} |
Closes
Split out from #8913
This just focuses on lock files and install states for all of our examples and starters. It's the first PR because it's probably the most important to establish. From here we can see what future changes are actually doing and something new can't come in and cause a different issue. Think of it as establishing a baseline.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: