fix import for RN 0.40+ #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, we'll probably release new version with this fix in next couple of days. Cheers. 🍺 |
|
thanks! :) |
|
Update is coming as part of this PR (#9) which has been tested with 0.37.0 - 0.41.0 versions of React Native. Thank you guys one more time for all the suggestions and help. |
|
And update is live: https://github.com/adjust/react_native_sdk/releases/tag/v4.11.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for your library!
We experienced an issue after updating to 0.40 version of React Native.
Duplicate interface definition for class 'RCTBridge'The reason was the check that
RCTBridgeModule.hwas imported.So I checked how it is implemented in CodePush and other libraries and changed the implementation to work analogically.
Currently it works well with RN 0.40+ app