Skip to content

Conversation

dhorelik
Copy link

the problem is that __has_include("RCTBridge.h") is somehow available to the compiler and it causes duplicate import errors. Due to that the current sdk version doesn’t work with RN 0.40 & 0.41.

@philipshurpik
Copy link
Contributor

@dhorelik I think maybe your version can give some unexpected scenarios... I saw how it's implemented in CodePush, Intercom and other libraries and implemented the same in #8

@uerceg
Copy link
Contributor

uerceg commented Feb 16, 2017

Yep, I think we will go for @philipshurpik's version, since it seems like more widely used one.

Never the less, thank you @dhorelik for the PR and suggestion.

Cheers guys.

@dhorelik
Copy link
Author

@philipshurpik that's the thing, I've checked the CodePush repo, they seem to have it the other way round, see the codebase
I don't think it's just caused by my setup, I've found a couple mentions on the issue, but haven't contacted the reporters.

@uerceg
Copy link
Contributor

uerceg commented Feb 16, 2017

🤔 Interesting. Thanks for sharing these infos. We will definitely test solution we add on pre 0.40.0 and 0.40.0++ versions as well to make sure that it works well in all scenarios.

@dhorelik
Copy link
Author

thanks, @uerceg. Ping me whenever you have any update

@uerceg
Copy link
Contributor

uerceg commented Feb 21, 2017

And in here as well - Update is coming as part of this PR (#9) which has been tested with 0.37.0 - 0.41.0 versions of React Native. Thank you guys one more time for all the suggestions and help.

@uerceg uerceg closed this Feb 21, 2017
@uerceg
Copy link
Contributor

uerceg commented Feb 21, 2017

@dhorelik
Copy link
Author

cool, thanks a lot, @uerceg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants