Skip to content

Release 5 - Update versions and release strings #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2020
Merged

Release 5 - Update versions and release strings #4289

merged 2 commits into from
Jul 31, 2020

Conversation

awjuliani
Copy link
Contributor

Proposed change(s)

Updates versions to Release 5.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@awjuliani awjuliani requested a review from surfnerd July 31, 2020 00:11
chriselion
chriselion approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not incrementing the C# package, right? That should save some time running the full yamato tests...

@chriselion
Copy link
Contributor

You're going to need to cherry-pick #4278 and #4282 to get yamato tests to pass.

@awjuliani
Copy link
Contributor Author

@chriselion Thanks for the heads-up. I get a merge conflict that I am not exactly sure how to resolve correctly, since I don't have experience with the yamato config files. Would you mind cherry-picking these for me?

@chriselion
Copy link
Contributor

chriselion commented Jul 31, 2020 •
edited
Loading

Sure, doing that in #4290 to keep them separate. I think you're OK to merge this in the meantime Merged that it to the release branch, and release branch to here.

@awjuliani
Copy link
Contributor Author

Thanks @chriselion I appreciate it!

@awjuliani awjuliani merged commit 4dd9dc5 into release_5_branch Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the r5-versions branch July 31, 2020 17:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surfnerd surfnerd Awaiting requested review from surfnerd

1 more reviewer

@chriselion chriselion chriselion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awjuliani @chriselion