Pass artifactory url for all pip calls in yamato #4282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Jul 29, 2020
| pip install grpcio-tools==1.13.0 --progress-bar=off | ||
| pip install mypy-protobuf==1.16.0 --progress-bar=off | ||
| pip install --upgrade pip --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple | ||
| pip install grpcio==1.28.1 grpcio-tools==1.13.0 protobuf==3.11.3 six==1.14.0 mypy-protobuf==1.16.0 --progress-bar=off --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple |
There was a problem hiding this comment.
I got the versions here from an older passing run of the proto generation test:
https://yamato.prd.cds.internal.unity3d.com/jobs/497-ml-agents/tree/master/.yamato%252Fprotobuf-generation-test.yml%2523test_mac_protobuf_generation/2066047/job/(log:Execution)
There was a problem hiding this comment.
Turns out that wasn't the cause of the delta (but still worth doing).
chriselion
commented
Jul 29, 2020
|
|
||
|
|
||
| class UnityToExternalProtoStub: | ||
| class UnityToExternalProtoStub(object): |
There was a problem hiding this comment.
Follow up jira: https://jira.unity3d.com/browse/MLA-1215
We should have run the proto check test when these were modified.
awjuliani
approved these changes
Jul 29, 2020
10 tasks
chriselion
pushed a commit
that referenced
this pull request
Jul 31, 2020
* pass artifactory url for all pip calls in yamato * pip proto generation libs * undo pyupgrade on generated code
surfnerd
pushed a commit
that referenced
this pull request
Aug 19, 2020
* pass artifactory url for all pip calls in yamato * pip proto generation libs * undo pyupgrade on generated code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Not sure if there's a good way to DRY this up. It should be redundant eventually when the CI images have a
pip.ini/pip.conffile that make this the default.