Skip to content

Conversation

peifeng-unity
Copy link
Contributor

Proposed change(s)

Add fetching public key from ubuntu keyserver

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

Tested by rebuilding the image

docker builder prune
docker build -t unity-robotics:pick-and-place -f docker/Dockerfile .

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@peifeng-unity peifeng-unity changed the title add updating public key [AIRO-751] add updating public key Jun 7, 2021
Copy link
Contributor

@LaurieCheers-unity LaurieCheers-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no context but assuming you've tested it this seems fine?

Copy link
Contributor

@at669 at669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this change when done on the object pose estimation repo and worked for me!

@peifeng-unity
Copy link
Contributor Author

I have no context but assuming you've tested it this seems fine?

Oh, yeah, Tested it and it works fine with fetching the key from the keyserver. It seems that the Ubuntu system updated the GPG key some time ago.

@peifeng-unity peifeng-unity merged commit 7037714 into dev Jun 7, 2021
@peifeng-unity peifeng-unity deleted the fix-docker-public-key branch June 7, 2021 20:27
peifeng-unity added a commit that referenced this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants