Skip to content

added chmod +x to Dockerfile to ensure the python scripts are executable #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2021
Merged

added chmod +x to Dockerfile to ensure the python scripts are executable #239

merged 1 commit into from
Jun 1, 2021

Conversation

hyounesy
Copy link
Contributor

Proposed change(s)

Added chmod +x to make sure all python scripts in niryo_moveit are executable after a docker image is built.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

  • built the docker image: 
    cd tutorials/pick_and_place$
docker build -t unity-robotics:pick-and-place -f docker/Dockerfile .
  • started the docker image: 
    docker run -it --rm -p 10000:10000 -p 5005:5005 unity-robotics:pick-and-place /bin/bash
  • checked that all scripts are executable: 
    ls -al src/niryo_moveit/scripts/
  • confirmed the ROS scripts are executing: 
    roslaunch niryo_moveit part_2.launch
roslaunch niryo_moveit part_3.launch
  • Also performed a negative test in which replaced chmod +x to chmod -x in the Docker file, and verified that scripts become not executable and both run scripts don't run due to wrong file permissions.

Test Configuration:

  • Unity Version: 2021.1.7f1
  • Unity machine OS + version: macOS Catalina: 10.15.7
  • ROS machine OS + version: Ubuntu 18.04, ROS Melodic on Docker
  • ROS–Unity communication: Docker

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the documentation as appropriate

Other comments

@hyounesy
Copy link
Contributor Author

This replaces the previous PR where the incorrect file mode was changed in the git rather than the docker.
#229

@hyounesy hyounesy mentioned this pull request May 28, 2021
Closed
10 tasks
@hyounesy hyounesy changed the title added chmod to make sure the python scripts are executable added chmod +x to Dockerfile to make sure the python scripts are executable May 28, 2021
@hyounesy hyounesy changed the title added chmod +x to Dockerfile to make sure the python scripts are executable added chmod +x to Dockerfile to ensure the python scripts are executable May 28, 2021
peifeng-unity
peifeng-unity approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@peifeng-unity peifeng-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyounesy hyounesy merged commit 85d50a9 into dev Jun 1, 2021
@hyounesy hyounesy deleted the hamid/make-scripts-executable branch June 1, 2021 20:57
sdiao added a commit that referenced this pull request Jun 1, 2021
@sdiao @mrpropellers
@peifeng-unity @vidurvij-Unity @LaurieCheers-unity @at669 @hyounesy @sarah-gibson
Merge Dev to Main for release 0.4.0 (#241)
0b08f4f 
* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* fixing typo in ros-unity service tutorial (#198)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Adding network troubleshooting doc. (#195)

* Adding network troubleshooting doc.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Resolve conflicts 2 (#233)

* Merging dev branch into main (#78)

* Reverting params.yaml and updating code in server_endpoint.md
* TcpServer class was renamed
* convert all files with dos2unix (#76)
* Minor tutorial tweaks, update version numbers

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>

* Updating instructions for URDF repository  (#71)

* 1. Adding images for URDF tutorial 2. Adding instructions highlighting Disable Collison tag

* Adding link to example of disable collision tag in the niryo_one URDF file

* Sarah/readme update (#112)

* Adding physics roadmap and minor formatting changes

* formatting nits

* Calling out feature requests

* Update for ROS-TCP-Connector namespace changes

* Mpinol/simrealrebased (#107)

* Adding sim and real pnp files.

* Update with new instructions (#147)

* Update tutorial text (#148)

* AIRO-405 Adding Yamato boilerplate to Robotics Hub (#144)

* Adding testing boilerplate

* Adding tests to run after message generation

* Tweaks to ensure run works in Bokken image

* Enabling audio by default, but disabling it in yamato config

* Hotfix: Remove DemoScripts asmdef

The DemoScripts.asmdef was a bit of experimental cruft that snuck in via
my Yamato changes. This causes Demo.cs to compile as an Editor script,
which  means it can no longer be instantiated in the scene hierarchy
(this breaks the demo).  Removing the asmdef puts things back to normal.

Tested by running the demo.

* Use latest main

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Fixing issue with Demo.cs not working with new URDF Importer co-routine (#162)

Co-authored-by: Devin Miller <[email protected]>

* Readme: New Link (#172)

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* README update

* PR feedback

* Blog post link update

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

* Added newsletter link (#175)

* remove stale merge

* Minor formmating

* Fix README and git sub module

* Revert unintentional change in urdf_appendix.md

* Add back tutorials/pick_and_place/ROS/src/ros_tcp_endpoint

Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>

* Update Demo (#235)

* Update Demo

* Minor fix

* Update tutorial manifest to use v0.4.0

* Update ros_tcp_endpoint module

* Update quick_setup version

* Update tutorial manifest

* added chmod to make sure the python scripts are executable (#239)

* Minor update in README.md

* minor fix

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>
sdiao added a commit that referenced this pull request Jun 1, 2021
@sdiao @mrpropellers
@peifeng-unity @vidurvij-Unity @LaurieCheers-unity @at669 @hyounesy @sarah-gibson
Merge Dev to Main for release 0.4.0 (#241) (#242)
1f10973 
* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* fixing typo in ros-unity service tutorial (#198)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Adding network troubleshooting doc. (#195)

* Adding network troubleshooting doc.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Resolve conflicts 2 (#233)

* Merging dev branch into main (#78)

* Reverting params.yaml and updating code in server_endpoint.md
* TcpServer class was renamed
* convert all files with dos2unix (#76)
* Minor tutorial tweaks, update version numbers

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>

* Updating instructions for URDF repository  (#71)

* 1. Adding images for URDF tutorial 2. Adding instructions highlighting Disable Collison tag

* Adding link to example of disable collision tag in the niryo_one URDF file

* Sarah/readme update (#112)

* Adding physics roadmap and minor formatting changes

* formatting nits

* Calling out feature requests

* Update for ROS-TCP-Connector namespace changes

* Mpinol/simrealrebased (#107)

* Adding sim and real pnp files.

* Update with new instructions (#147)

* Update tutorial text (#148)

* AIRO-405 Adding Yamato boilerplate to Robotics Hub (#144)

* Adding testing boilerplate

* Adding tests to run after message generation

* Tweaks to ensure run works in Bokken image

* Enabling audio by default, but disabling it in yamato config

* Hotfix: Remove DemoScripts asmdef

The DemoScripts.asmdef was a bit of experimental cruft that snuck in via
my Yamato changes. This causes Demo.cs to compile as an Editor script,
which  means it can no longer be instantiated in the scene hierarchy
(this breaks the demo).  Removing the asmdef puts things back to normal.

Tested by running the demo.

* Use latest main

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Fixing issue with Demo.cs not working with new URDF Importer co-routine (#162)

Co-authored-by: Devin Miller <[email protected]>

* Readme: New Link (#172)

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* README update

* PR feedback

* Blog post link update

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

* Added newsletter link (#175)

* remove stale merge

* Minor formmating

* Fix README and git sub module

* Revert unintentional change in urdf_appendix.md

* Add back tutorials/pick_and_place/ROS/src/ros_tcp_endpoint

Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>

* Update Demo (#235)

* Update Demo

* Minor fix

* Update tutorial manifest to use v0.4.0

* Update ros_tcp_endpoint module

* Update quick_setup version

* Update tutorial manifest

* added chmod to make sure the python scripts are executable (#239)

* Minor update in README.md

* minor fix

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpropellers mrpropellers Awaiting requested review from mrpropellers

1 more reviewer

@peifeng-unity peifeng-unity peifeng-unity approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyounesy @peifeng-unity