Adding network troubleshooting doc. #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mpinol merged 3 commits into dev from mpinol/ts

Apr 27, 2021

Contributor

mpinol commented Apr 7, 2021

Start of doc to add TCP Connector and Endpoint troubleshooting steps.

Contributor

at669 commented Apr 12, 2021

just to check, are there any explicit instructions to mention if the user is running ROS and Unity natively on the same machine, i.e. should there be anything to call out when ROS_IP and Unity_IP match?

sarah-gibson requested a review from hyounesy

April 20, 2021 22:08

sarah-gibson reviewed

View reviewed changes

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated

		`-p 10000:10000 -p 5005:5005`


		- On the ROS side, set `ROS IP` to `0.0.0.0`.

Contributor

sarah-gibson Apr 20, 2021

Looking at the pick-and-place tutorial, the set-up-workspace script does this:
echo "ROS_IP: $(hostname -i)" > $ROS_WORKSPACE/src/niryo_moveit/config/params.yaml
which assigns the IP address of the machine running ROS. Why is it different? Can you do either?

Contributor

sarah-gibson Apr 20, 2021

Also ROS_IP needs an underscore

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

hyounesy reviewed

View reviewed changes

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

hyounesy reviewed

View reviewed changes

Contributor

hyounesy left a comment •

edited

Loading

I think the document addresses the issues that I have encountered with. two overall comments:

I feel the structure can be further improved. perhaps the sections need to be organized, and steps numbered, to make it easier to follow? and perhaps a high level TOC at the top?
adding a few code snippets for the indicated items.

tutorials/ros_unity_integration/network_troubleshooting.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network_troubleshooting.md Outdated

		```ROS-Unity server listening on UNITY_IP_ADDRESS:5005```


		If the previous message is not shown and either of the following errors are thrown instead:

Contributor

hyounesy Apr 22, 2021

previous message -> previous message"s" ? (both / either/ or only the last one)?

at669 reviewed

View reviewed changes

tutorials/ros_unity_integration/network.md Outdated Show resolved Hide resolved

Unity-Technologies deleted a comment


          Adding network troubleshooting doc.

50a3922

mpinol force-pushed the mpinol/ts branch from 98e6700 to 50a3922 Compare

April 26, 2021 21:15

sarah-gibson approved these changes

View reviewed changes

tutorials/ros_unity_integration/network.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network.md Outdated Show resolved Hide resolved

tutorials/ros_unity_integration/network.md Outdated Show resolved Hide resolved

mpinol and others added 2 commits

April 27, 2021 12:58


          Minor copy updates.

bba0af0


          Merge branch 'dev' into mpinol/ts

c2ff5f7

mpinol merged commit 32070f8 into dev

mpinol deleted the mpinol/ts branch

April 27, 2021 20:00

peifeng-unity pushed a commit that referenced this pull request


          Adding network troubleshooting doc. (#195)

84adaf4

* Adding network troubleshooting doc.

sdiao pushed a commit that referenced this pull request


          Adding network troubleshooting doc. (#195)

1edf8fd

* Adding network troubleshooting doc.

sdiao added a commit that referenced this pull request


          Merge Dev to Main for release 0.4.0 (#241)

0b08f4f

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* fixing typo in ros-unity service tutorial (#198)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Adding network troubleshooting doc. (#195)

* Adding network troubleshooting doc.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Resolve conflicts 2 (#233)

* Merging dev branch into main (#78)

* Reverting params.yaml and updating code in server_endpoint.md
* TcpServer class was renamed
* convert all files with dos2unix (#76)
* Minor tutorial tweaks, update version numbers

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>

* Updating instructions for URDF repository  (#71)

* 1. Adding images for URDF tutorial 2. Adding instructions highlighting Disable Collison tag

* Adding link to example of disable collision tag in the niryo_one URDF file

* Sarah/readme update (#112)

* Adding physics roadmap and minor formatting changes

* formatting nits

* Calling out feature requests

* Update for ROS-TCP-Connector namespace changes

* Mpinol/simrealrebased (#107)

* Adding sim and real pnp files.

* Update with new instructions (#147)

* Update tutorial text (#148)

* AIRO-405 Adding Yamato boilerplate to Robotics Hub (#144)

* Adding testing boilerplate

* Adding tests to run after message generation

* Tweaks to ensure run works in Bokken image

* Enabling audio by default, but disabling it in yamato config

* Hotfix: Remove DemoScripts asmdef

The DemoScripts.asmdef was a bit of experimental cruft that snuck in via
my Yamato changes. This causes Demo.cs to compile as an Editor script,
which  means it can no longer be instantiated in the scene hierarchy
(this breaks the demo).  Removing the asmdef puts things back to normal.

Tested by running the demo.

* Use latest main

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Fixing issue with Demo.cs not working with new URDF Importer co-routine (#162)

Co-authored-by: Devin Miller <[email protected]>

* Readme: New Link (#172)

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* README update

* PR feedback

* Blog post link update

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

* Added newsletter link (#175)

* remove stale merge

* Minor formmating

* Fix README and git sub module

* Revert unintentional change in urdf_appendix.md

* Add back tutorials/pick_and_place/ROS/src/ros_tcp_endpoint

Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>

* Update Demo (#235)

* Update Demo

* Minor fix

* Update tutorial manifest to use v0.4.0

* Update ros_tcp_endpoint module

* Update quick_setup version

* Update tutorial manifest

* added chmod to make sure the python scripts are executable (#239)

* Minor update in README.md

* minor fix

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>

sdiao added a commit that referenced this pull request


          Merge Dev to Main for release 0.4.0 (#241) (#242)

1f10973

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* fixing typo in ros-unity service tutorial (#198)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Adding network troubleshooting doc. (#195)

* Adding network troubleshooting doc.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Resolve conflicts 2 (#233)

* Merging dev branch into main (#78)

* Reverting params.yaml and updating code in server_endpoint.md
* TcpServer class was renamed
* convert all files with dos2unix (#76)
* Minor tutorial tweaks, update version numbers

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>

* Updating instructions for URDF repository  (#71)

* 1. Adding images for URDF tutorial 2. Adding instructions highlighting Disable Collison tag

* Adding link to example of disable collision tag in the niryo_one URDF file

* Sarah/readme update (#112)

* Adding physics roadmap and minor formatting changes

* formatting nits

* Calling out feature requests

* Update for ROS-TCP-Connector namespace changes

* Mpinol/simrealrebased (#107)

* Adding sim and real pnp files.

* Update with new instructions (#147)

* Update tutorial text (#148)

* AIRO-405 Adding Yamato boilerplate to Robotics Hub (#144)

* Adding testing boilerplate

* Adding tests to run after message generation

* Tweaks to ensure run works in Bokken image

* Enabling audio by default, but disabling it in yamato config

* Hotfix: Remove DemoScripts asmdef

The DemoScripts.asmdef was a bit of experimental cruft that snuck in via
my Yamato changes. This causes Demo.cs to compile as an Editor script,
which  means it can no longer be instantiated in the scene hierarchy
(this breaks the demo).  Removing the asmdef puts things back to normal.

Tested by running the demo.

* Use latest main

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* update package import urls for tcp connector and urdf importer (#166)

* Update urdf_tutorial.md (#168)

* Added M prefixes to docs (#167)

* Adding Editor version to Ros Integration Readme

* Updating package dependencies to proper versions

Pick and place tutorial was failing to compile its scripts because
the package manifest was pointing to an older version of
ROS-TCP-Connector.  Updated the manifest and also pulled latest changes
for ros_tcp_endpoint.

Tested by running DemoScene

* Updating Contribution Content (#186)

* Contributing content

* PR feedback

* Adding PR template (#191)

* Unity service example (#199)

* added example of implementing a UnityService

* adding tutorial for unity service

* added a couple comments to the example code

* typos and code standard fixes

* consistency: changing the service name for position_service to pos_srv

* updating the tutorial to match the corresponding script

* Update the list of new physics features (#204)

* add new sections for the released new physics features

Co-authored-by: Amanda <[email protected]>

* Update to 0.3.0 (#207)

* Removing old version tags from git URLs in quick_setup

Addressing user issue #209. Our quick_setup guide was still recommending users check out v.0.2.0 of our packages. Removed the reference to a specific package version and instead included a note that users can explicitly declare a package version if desired.

Tested by making the change locally in the package manifest.

* Updating tutorials to the glorious new world (#211)

* add changelog (#218)

add changelog

* Forum links to README, config.yml (#219)

* Add linter (#227)

* Add linter and pre-commit hooks

* Formatting

* Remove setting up ruby

* Fixing issue with Demo.cs not working with new URDF Importer co-routine (#162)

Co-authored-by: Devin Miller <[email protected]>

* Readme: New Link (#172)

* Fixing issue with Demo.cs not working with new URDF Importer co-routine

* remove unused import (#163)

* README update

* PR feedback

* Blog post link update

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>

* Added newsletter link (#175)

* remove stale merge

* Minor formmating

* Fix README and git sub module

* Revert unintentional change in urdf_appendix.md

* Add back tutorials/pick_and_place/ROS/src/ros_tcp_endpoint

Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>

* Update Demo (#235)

* Update Demo

* Minor fix

* Update tutorial manifest to use v0.4.0

* Update ros_tcp_endpoint module

* Update quick_setup version

* Update tutorial manifest

* added chmod to make sure the python scripts are executable (#239)

* Minor update in README.md

* minor fix

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>

Co-authored-by: Devin Miller <[email protected]>
Co-authored-by: peifeng-unity <[email protected]>
Co-authored-by: vidurvij-Unity <[email protected]>
Co-authored-by: LaurieCheers-unity <[email protected]>
Co-authored-by: Devin Miller (Unity) <[email protected]>
Co-authored-by: Amanda <[email protected]>
Co-authored-by: Hamid Younesy <[email protected]>
Co-authored-by: Peifeng Jing <[email protected]>
Co-authored-by: sarah-gibson <[email protected]>

peifeng-unity added a commit that referenced this pull request


          Adding network troubleshooting doc. (#195)

045e5ee

* Adding network troubleshooting doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet