Get settings info out of headers, out of libutil #11033
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
settings-split
branch
from
58f4d9e to
13d573b
Compare
github-actions
bot
added
store
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
settings-split
branch
from
245be94 to
88c62b2
Compare
Ericson2314
force-pushed
the
settings-split
branch
from
88c62b2 to
6c70227
Compare
github-actions
bot
added
the
fetching
Ericson2314
force-pushed
the
settings-split
branch
from
6c70227 to
64ba88c
Compare
Ericson2314
force-pushed
the
settings-split
branch
5 times, most recently
from
4722825 to
d4a6f78
Compare
Ericson2314
force-pushed
the
settings-split
branch
6 times, most recently
from
a278525 to
6c83d93
Compare
Ericson2314
force-pushed
the
settings-split
branch
5 times, most recently
from
87b25c1 to
74f6757
Compare
Ericson2314
force-pushed
the
settings-split
branch
4 times, most recently
from
116853c to
4741f60
Compare
Ericson2314
force-pushed
the
settings-split
branch
2 times, most recently
from
bcf160c to
7beb721
Compare
Motivation: See the linked issues for details. The most notable user-relevant bits are: - This cleans up the `MountedSSHStore`: decomposed into its orthogonal parts - This brings us pretty close to being able to then implement a JSON-based config. - Store query parameters can be JSON - Stores can entirely be specified via JSON objects, but this is not yet hooked up to anything. Also behind the scenes have these benefits: 1. The docs are moved out of the headers, good for less rebuilding when they changes 2. Stores are always constructed from store configs 3. Use JSON, avoid custom serializers Context: Part of NixOS#11106 Co-Authored-By: Robert Hensing <[email protected]> Co-authored-by: Sergei Zimmerman <[email protected]>
This works for most cases.
Also make a tiny bit of progress on libstore
Ericson2314
force-pushed
the
settings-split
branch
from
7beb721 to
0ed87a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Want to separate the current configuration script and args infra from the core libraries (libstore and libexpr), where it doesn't belong, and push down into libmain.
Context
Do not review by commits
Progress on #5638
Depends on #11139
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.