-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Thinking through #5603, and the two getDefaultSystemFeatures
reminded me of this:
-
We have many global settings that should be per-store.
thisSytem
andextraPlatforms
are good examples. This works best after SplitStore
class #5729 so that we don't pollute stores likeHttpBinaryCacheStore
with these new per-store options that don't make sense for them. -
We have too much ad-hoc logic around build remotes that should be fixed up to use per-store settings instead, as we did before with system features in 4720853
- We should probably make stores that can build a subclass of stores that just are read/written. Then we don't have to do silly things like say what "extraPlatforms"
s3://...
has.
- We should probably make stores that can build a subclass of stores that just are read/written. Then we don't have to do silly things like say what "extraPlatforms"
-
Separate stores for evaluation, building and storing the result #5025 (comment) remains a very good idea. Then many of the remaining settings which aren't per-store would make sense as an additional config parameter to this now-freestanding (not
Store
method) function. -
Finally, there may be global settings that are for the libstore layer at all, and they can be moved to another downstream library.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status