-
Notifications
You must be signed in to change notification settings - Fork 374
[test] add browser tests for Vue node multiline string widgets #5819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benceruleanlu
merged 4 commits into
main
from
vue-nodes/test/multiline-string-widget-tests
Sep 27, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
browser_tests/tests/vueNodes/widgets/text/multilineStringWidget.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import { | ||
type ComfyPage, | ||
comfyExpect as expect, | ||
comfyPageFixture as test | ||
} from '../../../../fixtures/ComfyPage' | ||
|
||
test.describe('Vue Multiline String Widget', () => { | ||
test.beforeEach(async ({ comfyPage }) => { | ||
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true) | ||
await comfyPage.vueNodes.waitForNodes() | ||
}) | ||
|
||
const getFirstClipNode = (comfyPage: ComfyPage) => | ||
comfyPage.vueNodes.getNodeByTitle('CLIP Text Encode (Prompt)').first() | ||
|
||
const getFirstMultilineStringWidget = (comfyPage: ComfyPage) => | ||
getFirstClipNode(comfyPage).getByRole('textbox', { name: 'text' }) | ||
|
||
test('should allow entering text', async ({ comfyPage }) => { | ||
const textarea = getFirstMultilineStringWidget(comfyPage) | ||
await textarea.fill('Hello World') | ||
await expect(textarea).toHaveValue('Hello World') | ||
await textarea.fill('Hello World 2') | ||
await expect(textarea).toHaveValue('Hello World 2') | ||
}) | ||
|
||
test('should support entering multiline content', async ({ comfyPage }) => { | ||
const textarea = getFirstMultilineStringWidget(comfyPage) | ||
|
||
const multilineValue = ['Line 1', 'Line 2', 'Line 3'].join('\n') | ||
|
||
await textarea.fill(multilineValue) | ||
await expect(textarea).toHaveValue(multilineValue) | ||
}) | ||
|
||
test('should retain value after focus changes', async ({ comfyPage }) => { | ||
const textarea = getFirstMultilineStringWidget(comfyPage) | ||
|
||
await textarea.fill('Keep me around') | ||
|
||
// Click another node | ||
const loadCheckpointNode = | ||
comfyPage.vueNodes.getNodeByTitle('Load Checkpoint') | ||
await loadCheckpointNode.click() | ||
await getFirstClipNode(comfyPage).click() | ||
|
||
await expect(textarea).toHaveValue('Keep me around') | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: seems a bit brittle, could use getByTestId, but it's not like our fixtures/helpers are good anyway