Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 27, 2025

Summary

Added Playwright E2E tests for Vue multiline string widget functionality to ensure text input and persistence work correctly.

Changes

  • What: Created browser tests for multiline string widget in Vue nodes implementation, covering text input, multiline text input, and focus change behavior.

Review Focus

Test coverage for text input persistence across focus changes and multiline content handling in the CLIP Text Encode widget.

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 27, 2025
Copy link

github-actions bot commented Sep 27, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/27/2025, 07:37:58 PM UTC

📈 Summary

  • Total Tests: 470
  • Passed: 439 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 432 / ❌ 0 / ⚠️ 2 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Comment on lines +13 to +17
const getFirstClipNode = (comfyPage: ComfyPage) =>
comfyPage.vueNodes.getNodeByTitle('CLIP Text Encode (Prompt)').first()

const getFirstMultilineStringWidget = (comfyPage: ComfyPage) =>
getFirstClipNode(comfyPage).getByRole('textbox', { name: 'text' })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems a bit brittle, could use getByTestId, but it's not like our fixtures/helpers are good anyway

@benceruleanlu benceruleanlu merged commit b0d2b44 into main Sep 27, 2025
21 checks passed
@benceruleanlu benceruleanlu deleted the vue-nodes/test/multiline-string-widget-tests branch September 27, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:testing area:vue-migration size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants