Skip to content

Internally expose _panningEpsilon and _rotationEpsilon which are used to calculate inertial limit #17197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2025
Merged

Internally expose _panningEpsilon and _rotationEpsilon which are used to calculate inertial limit #17197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7c5860
use localspeed rather than const speed
Sep 25, 2025
eb7f516
add speed multiplication to alpha/beta inertia calc
Sep 25, 2025
fad8dc5
update logic to take deltaTime into account
Sep 29, 2025
9ebf2f3
lint
Sep 29, 2025
5088e02
allow for overriding epsilon in beforeRender
Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/dev/core/src/Cameras/arcRotateCamera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,9 +1040,11 @@ export class ArcRotateCamera extends TargetCamera {
}

this.inputs.checkInputs();

let hasUserInteractions = false;

const inertialPanningLimit = this.speed * this._panningEpsilon;
const inertialRotationLimit = this.speed * this._rotationEpsilon;

// Inertia
if (this.inertialAlphaOffset !== 0 || this.inertialBetaOffset !== 0 || this.inertialRadiusOffset !== 0) {
hasUserInteractions = true;
Expand All @@ -1062,13 +1064,13 @@ export class ArcRotateCamera extends TargetCamera {
this.inertialAlphaOffset *= this.inertia;
this.inertialBetaOffset *= this.inertia;
this.inertialRadiusOffset *= this.inertia;
if (Math.abs(this.inertialAlphaOffset) < Epsilon) {
if (Math.abs(this.inertialAlphaOffset) < inertialRotationLimit) {
this.inertialAlphaOffset = 0;
}
if (Math.abs(this.inertialBetaOffset) < Epsilon) {
if (Math.abs(this.inertialBetaOffset) < inertialRotationLimit) {
this.inertialBetaOffset = 0;
}
if (Math.abs(this.inertialRadiusOffset) < this.speed * Epsilon) {
if (Math.abs(this.inertialRadiusOffset) < inertialRotationLimit) {
this.inertialRadiusOffset = 0;
}
}
Expand Down Expand Up @@ -1114,10 +1116,10 @@ export class ArcRotateCamera extends TargetCamera {
this.inertialPanningX *= this.panningInertia;
this.inertialPanningY *= this.panningInertia;

if (Math.abs(this.inertialPanningX) < this.speed * Epsilon) {
if (Math.abs(this.inertialPanningX) < inertialPanningLimit) {
this.inertialPanningX = 0;
}
if (Math.abs(this.inertialPanningY) < this.speed * Epsilon) {
if (Math.abs(this.inertialPanningY) < inertialPanningLimit) {
this.inertialPanningY = 0;
}
}
Expand Down
25 changes: 20 additions & 5 deletions packages/dev/core/src/Cameras/targetCamera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,19 @@ export class TargetCamera extends Camera {
*/
public inverseRotationSpeed = 0.2;

/**
* @internal
* @experimental
* Can be used to change clamping behavior for inertia. Hook into onBeforeRenderObservable to change the value per-frame
*/
public _panningEpsilon = Epsilon;
/**
* @internal
* @experimental
* Can be used to change clamping behavior for inertia. Hook into onBeforeRenderObservable to change the value per-frame
*/
public _rotationEpsilon = Epsilon;

/**
* Define the current target of the camera as an object or a position.
* Please note that locking a target will disable panning.
Expand Down Expand Up @@ -391,28 +404,30 @@ export class TargetCamera extends Camera {
}
}

const inertialPanningLimit = this.speed * this._panningEpsilon;
const inertialRotationLimit = this.speed * this._rotationEpsilon;
// Inertia
if (needToMove) {
if (Math.abs(this.cameraDirection.x) < this.speed * Epsilon) {
if (Math.abs(this.cameraDirection.x) < inertialPanningLimit) {
this.cameraDirection.x = 0;
}

if (Math.abs(this.cameraDirection.y) < this.speed * Epsilon) {
if (Math.abs(this.cameraDirection.y) < inertialPanningLimit) {
this.cameraDirection.y = 0;
}

if (Math.abs(this.cameraDirection.z) < this.speed * Epsilon) {
if (Math.abs(this.cameraDirection.z) < inertialPanningLimit) {
this.cameraDirection.z = 0;
}

this.cameraDirection.scaleInPlace(this.inertia);
}
if (needToRotate) {
if (Math.abs(this.cameraRotation.x) < this.speed * Epsilon) {
if (Math.abs(this.cameraRotation.x) < inertialRotationLimit) {
this.cameraRotation.x = 0;
}

if (Math.abs(this.cameraRotation.y) < this.speed * Epsilon) {
if (Math.abs(this.cameraRotation.y) < inertialRotationLimit) {
this.cameraRotation.y = 0;
}
this.cameraRotation.scaleInPlace(this.inertia);
Expand Down