Fix temperature value calculation for ds18s20 #97014
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DS18S20 returns a 9 bit temperature value. The value is a signed integer scaled by a factor of two, for 0.5 °C resolution. The integer part was calculated correctly using integer division by two. The decimal had one zero too much in the multiplication factor, thus would either add 0 or 5 to the total value instead of 0 or 0.5.