Skip to content

Conversation

sasodoma
Copy link

@sasodoma sasodoma commented Oct 4, 2025

The DS18S20 returns a 9 bit temperature value. The value is a signed integer scaled by a factor of two, for 0.5 °C resolution. The integer part was calculated correctly using integer division by two. The decimal had one zero too much in the multiplication factor, thus would either add 0 or 5 to the total value instead of 0 or 0.5.

Copy link

github-actions bot commented Oct 4, 2025

Hello @sasodoma, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@sasodoma
Copy link
Author

sasodoma commented Oct 4, 2025

Reading the commit message guidelines, I realized that my commit message does not follow them. What is the simplest way for me to correct that?

@pyhys
Copy link
Contributor

pyhys commented Oct 4, 2025

In general, to modify the commit message use git commit --amend and then edit the message. Use force-push to send it to github, typically git push origin YOUR_BRANCH_NAME -f

That will change the commit message, as seen on https://github.com/zephyrproject-rtos/zephyr/pull/97014/commits

If you would like to change the text on the #97014 page, click the three dots and then "Edit".

I do not have permissions to approve the workflow. If it takes several days before someone approves the workflow, then I suggest you ask someone on discord to approve it. Once you have previous contributions to the project, you do not need to wait for approval to run the workflow.

The millionths value is calculated incorrectly.
The sensor has a precision of 0.5 which is 500000 millionths, but
there is an extra zero in the code. This fix removes the extra zero.

Signed-off-by: Sašo Domadenik <[email protected]>
@sasodoma
Copy link
Author

sasodoma commented Oct 4, 2025

Thank you, I wasn't sure if it was ok to amend and force push. I have now updated the commit message to be in line with the guidelines.

Copy link

sonarqubecloud bot commented Oct 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors platform: ADI Analog Devices, Inc. size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants