Linux filesystem #1433
Open
Linux filesystem #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwrsandman
force-pushed
the
linux_filesystem
branch
from
6d0338b to
10ea3fa
Compare
|
This looks good; in future it may be worth defining the expected path seperator used by the xbox somewhere useful The tests you've added could perhaps be expanded to test resolving canonicalized paths correctly |
bwrsandman
force-pushed
the
linux_filesystem
branch
from
0fdbcde to
85ad6d7
Compare
bwrsandman
force-pushed
the
linux_filesystem
branch
from
e4822b1 to
358a2dd
Compare
|
seems need rebase greetings |
bwrsandman
force-pushed
the
linux_filesystem
branch
from
358a2dd to
0c57001
Compare
|
Removed the use of templates to unify wstrings and strings as was mentioned by one of the maintainers in an earlier PR. |
bwrsandman
force-pushed
the
linux_filesystem
branch
2 times, most recently
from
e6fb0e5 to
03145ba
Compare
JoelLinn
suggested changes
Apr 8, 2020
JoelLinn
suggested changes
Apr 8, 2020
bwrsandman
force-pushed
the
linux_filesystem
branch
3 times, most recently
from
34098b0 to
bfa387d
Compare
bwrsandman
force-pushed
the
linux_filesystem
branch
from
bfa387d to
89adec9
Compare
Triang3l
reviewed
May 7, 2020
JoelLinn
reviewed
Nov 10, 2020
bwrsandman
force-pushed
the
linux_filesystem
branch
5 times, most recently
from
f76b800 to
0d31ef7
Compare
bwrsandman
force-pushed
the
linux_filesystem
branch
from
0d31ef7 to
48fb203
Compare
bwrsandman
force-pushed
the
linux_filesystem
branch
from
48fb203 to
992d127
Compare
va_list are not guarenteed to maintain their values after being used. With clang on Linux, args is undefined after fetching length and will print "(null)". Copy args into another va_list before getting length to prevent this. Add tests.
Print build version and date in the same way as the windows main
Skip recursive "." and ".." paths. Join paths instead of concatenating them. Assert stat return code.
Remove unused platform_linux reference. Replace C-style header uses. Replace C-style NULL with nullptr. Replace stdlib assert with xenia assert. Fix spelling
Fill in name, path and total_size. Correct convertUnixtimeToWinFiletime which was using deprecated stat function without nanoseconds. It now includes nanoseconds. Add unit test for file and folder info.
bwrsandman
force-pushed
the
linux_filesystem
branch
from
992d127 to
31744ae
Compare
|
@bwrsandman You can remove the last clock commit from this PR, it's in master now |
Triang3l
force-pushed
the
linux_filesystem
branch
from
31744ae to
75849c8
Compare
Done! :) |
|
Needs another rebase after 6ce5330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are filesystem and string changes to the emulator to work better on Linux. The changes help getting Xenia up and running but they need to be combined with the other Linux PRs to see the full working benefit. See #1430.
Changes
Previous state
xenia.logand was unable to open a file there.State after fix coupled with other Linux fixes