Integrate with the resizable buffers proposal #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
May 19, 2021
|
Looks good to me as well. (I still think we need to do #961 (comment), but that doesn't really influence this I think.) |
Agree, if SABs get their own IDL type, [AllowResizable] will compose with that type as well. |
|
@syg I noticed resizable buffers is at stage 3. And, this is probably worth landing since it helps prohibit resizable buffers from making their way into Web APIs that don't expect them. Should we merge? |
|
Good call, this had fallen off my radar. I'll remove the draft label. |
This commit adds the [AllowResizable] extended attribute, which allow BufferSources to take resizable buffers. It composes with [AllowShared] in the obvious way. The default behavior is unchanged, with only fixed-length buffers allowed. Proposal link: https://github.com/tc39/proposal-resizablearraybuffer
domenic
force-pushed
the
resizable-buffer-integration
branch
from
45168db to
51bc49a
Compare
domenic
pushed a commit
to jsdom/webidl-conversions
that referenced
this pull request
Sep 9, 2025
Implements the [AllowResizable] attribute introduced in whatwg/webidl#982.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the [AllowResizable] extended attribute, which allow
BufferSources to take resizable buffers. It composes with [AllowShared]
in the obvious way. The default behavior is unchanged, with only
fixed-length buffers allowed.
Proposal link: https://github.com/tc39/proposal-resizablearraybuffer
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Aug 12, 2021, 7:12 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.