Skip to content

Define getSVGDocument() in terms of content document #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Define getSVGDocument() in terms of content document #5109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88cbe99
Define getSVGDocument() in terms of content document
annevk Nov 25, 2019
8bd17f6
ty ci
annevk Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 13 additions & 25 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39550,19 +39550,13 @@ interface <dfn>HTMLAreaElement</dfn> : <span>HTMLElement</span> {

<hr>


<dl class="domintro">

<dt><var>doc</var> = <var>iframe</var> . <code subdfn data-x="dom-media-getSVGDocument">getSVGDocument</code>()</dt>
<dt><var>doc</var> = <var>embed</var> . <code data-x="dom-media-getSVGDocument">getSVGDocument</code>()</dt>
<dt><var>doc</var> = <var>object</var> . <code data-x="dom-media-getSVGDocument">getSVGDocument</code>()</dt>

<dd>

<p>Returns the <code>Document</code> object, in the case of <code>iframe</code>, <code>embed</code>, or <code>object</code> elements being used to embed SVG images.</p>

</dd>

<dd><p>Returns the <code>Document</code> object, in the case of <code>iframe</code>,
<code>embed</code>, or <code>object</code> elements being used to embed SVG.</p></dd>
</dl>

<div w-nodev>
Expand All @@ -39571,28 +39565,22 @@ interface <dfn>HTMLAreaElement</dfn> : <span>HTMLElement</span> {
the following steps:</p>

<ol>
<li><p>Let <var>document</var> be this element's <span
data-x="concept-bcc-content-document">content document</span>.</p></li>

<li><p>If the element's <span>nested browsing context</span> is null, then return null.</p></li>

<li><p>If the <span>origin</span> of the <span>active document</span> of the <span>nested
browsing context</span> is not <span>same origin-domain</span> with the element's <span>node
document</span>'s <span>origin</span>, then return null.</p></li>

<li><p>If the <span>nested browsing context</span>'s <span>active document</span> was created by
the <span data-x="navigate-xml">page load processing model for XML files</span> section because
the <span data-x="Content-Type sniffing">computed type of the resource</span> in the
<span>navigate</span> algorithm was <code>image/svg+xml</code>, then return that
<code>Document</code> object.</p></li>

<li><p>Otherwise, return null.</p></li>
<li><p>If <var>document</var> is non-null and was created by the <span data-x="navigate-xml">page
load processing model for XML files</span> section because the <span data-x="Content-Type
sniffing">computed type of the resource</span> in the <span>navigate</span> algorithm was
<code>image/svg+xml</code>, then return <var>document</var>.</p></li>
<!-- Ideally this would check a property of the document. -->

<li><p>Return null.</p></li>
</ol>

</div>




<h4><dfn>Dimension attributes</dfn></h4>

<p><span w-nodev><strong>Author requirements</strong>:</span> The <dfn><code
Expand Down Expand Up @@ -78766,9 +78754,9 @@ dictionary <dfn>DragEventInit</dfn> : <span>MouseEventInit</span> {

<li><p>Let <var>document</var> be <var>context</var>'s <span>active document</span>.</p></li>

<li><p>If <var>document</var>'s <span>origin</span> and the <span
data-x="concept-settings-object-origin">origin</span> specified by the <span>current settings
object</span> are not <span>same origin-domain</span>, then return null.</p></li>
<li><p>If <var>document</var>'s <span>origin</span> and <var>container</var>'s <span>node
document</span>'s <span>origin</span> are not <span>same origin-domain</span>, then return
null.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation for this change from checking the current settings object to checking container's node document? Did you mean to check both? Or is there a reason why checking both would be redundant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It aligns it with getSVGDocument() which is how implementations do it, as far as I can tell.


<li><p>Return <var>document</var>.</p></li>
</ol>
Expand Down