Tofe/only saved wifi #313
Open
Tofe/only saved wifi #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should functionaly equivalent to the previous version.
|
@Tofee Seems this one got never merged. Seems this is partly the Settings QML app migration so we'd need that. I guess we still need to merge this all? |
|
Well, it looks like it's wouldn't hurt, yes. The "only show saved WiFi networks" can be discussed though, and that's probably why I didn't PR it yet... and then forgot about it. |
|
@Tofee Well it's a PR ;) "Only show saved WiFi networks" is a bit confusing maybe? Users would expect to see all? At least that's what legacy webOS 2.x and 3.x do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.