-
Notifications
You must be signed in to change notification settings - Fork 223
Added the registration JSON file for "webplus" DID method. #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the proposal, I am missing privacy and security sections as per the sectionhttps://w3c.github.io/did/#security-requirements and https://w3c.github.io/did/#privacy-requirements. Am I missing something from the document?
Hi @gatemezing -- it's here: https://ledgerdomain.github.io/did-webplus-spec/#security-considerations -- though perhaps it's confusing that it's in the appendix. I'll move it into a more central place, and post again here when updated. Thanks for bringing attention to that! |
Ok, it's updated -- see https://ledgerdomain.github.io/did-webplus-spec/#security-and-privacy-considerations |
I've resolved the affiliation check. Not sure how to kick off the automated check to update that. |
vdods marked as non substantive for IPR from ash-nazg. |
Hi there! Can I get a re-review on this? Thank you. |
Signed-off-by: Victor Dods <[email protected]>
564baf4
to
a5698a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meets minimum registration requirements.
As @msporny notes, the registration requirements are met. While not a concern with with the registration, I did note something I hadn't realized in my previous readings of did:webplus. The deliberate use of the "/" as part of the DID seems inconsistent with the DID Core spec. The examples in Section 4.2 are DID URLs vs. DIDs, as they seem to presented as. The DIDs stop at the first slash "/", so technically, the only two DIDs in the list are Not that the PR is out of date and needs to be updated before it can be merged. |
Thanks for reviewing and merging! You're right Stephen -- I hadn't noticed that '/' was not present in the DID syntax. I had read through the long conversations in the did:web Github repo regarding DID syntax for did:web and potential simplifications to deriving the DID document resolution URL, which included discussion around '/' vs ':' to denote path components in the method-specific identifier, and I suppose I incorrectly inferred from that that '/' was a valid character. I'll need to change the did:webplus spec to use colons instead of slashes. |
Instructions for Pull Requests
Please read these instructions thoroughly in order to ensure that your pull request is processed in a timely manner. This document contains detailed instructions for registering a DID Method. If your pull request concerns some other change to the repository, you may delete all of the text in this text box and write up a more relevant description.
There is a DID Method Registration form below that MUST be included in a DID Method Registration Request. The form includes check boxes that you are expected to fill out when you submit your request.
Once you submit your request, your pull request will be reviewed by the registry editors. Changes regarding the required criteria may be requested. If there are no objections or changes requested, your DID method will be registered after a minimum of 7 days.
DID Method Registration Process
In order to register a new DID method, you must add a JSON file to the ./methods directory.
Here is an example registration entry:
Your Pull Request will be automatically validated, please ensure that all of the automated tests pass (no errors reported) or your submission will not be reviewed. Common reasons for failed validation includes invalidly formatted JSON files and missing mandatory fields.
----- DID METHOD REGISTRATION FORM: DELETE EVERYTHING ABOVE THIS LINE ------
DID Method Registration
As a DID method registrant, I have ensured that my DID method registration complies with the following statements:
contactEmail
address [OPTIONAL].verifiableDataRegistry
entry [OPTIONAL].