Skip to content

feat: use type=module in nightwatch projects #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat: use type=module in nightwatch projects #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f44c05b
feat: use type=module in nightwatch projects
cexbrayat Dec 11, 2023
12802b3
chore: revert submodule to the previous release
haoqunjiang Dec 13, 2023
0df8771
chore: comment out custom commands and assertions types
haoqunjiang Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...late/config/nightwatch/nightwatch.conf.js → ...ate/config/nightwatch/nightwatch.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ module.exports = {
page_objects_path: [],

// See https://nightwatchjs.org/guide/extending-nightwatch/adding-custom-commands.html
custom_commands_path: ['nightwatch/custom-commands'],
custom_commands_path: [],

// See https://nightwatchjs.org/guide/extending-nightwatch/adding-custom-assertions.html
custom_assertions_path: ['nightwatch/custom-assertions'],
custom_assertions_path: [],

// See https://nightwatchjs.org/guide/extending-nightwatch/adding-plugins.html
plugins: ['@nightwatch/vue'],
Expand Down
45 changes: 0 additions & 45 deletions template/config/nightwatch/nightwatch/custom-assertions/elementHasCount.js
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions template/config/nightwatch/nightwatch/custom-assertions/elementHasCount.ts
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions template/config/nightwatch/nightwatch/custom-commands/strictClick.js
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions template/config/nightwatch/nightwatch/custom-commands/strictClick.ts
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions template/config/nightwatch/nightwatch/nightwatch.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ import { NightwatchCustomAssertions, NightwatchCustomCommands } from 'nightwatch

declare module 'nightwatch' {
interface NightwatchCustomAssertions {
elementHasCount: (selector: string, count: number) => NightwatchBrowser
// Add your custom assertions' types here
// elementHasCount: (selector: string, count: number) => NightwatchBrowser
}

interface NightwatchCustomCommands {
strictClick: (selector: string) => NightwatchBrowser
// Add your custom commands' types here
// strictClick: (selector: string) => NightwatchBrowser
}
}
1 change: 0 additions & 1 deletion template/config/nightwatch/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"type": "commonjs",
"scripts": {
"test:e2e": "nightwatch tests/e2e/*"
},
Expand Down